From: "Metzger, Markus T" <markus.t.metzger@intel.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"markus.t.metzger@gmail.com" <markus.t.metzger@gmail.com>
Subject: RE: [PATCH 2/3] record-btrace, disas: omit pc prefix
Date: Thu, 28 Feb 2013 07:45:00 -0000 [thread overview]
Message-ID: <A78C989F6D9628469189715575E55B2307B86928@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <20130227075925.GA5003@host2.jankratochvil.net>
> -----Original Message-----
> From: Jan Kratochvil [mailto:jan.kratochvil@redhat.com]
> Sent: Wednesday, February 27, 2013 8:59 AM
> To: Metzger, Markus T
> Cc: gdb-patches@sourceware.org; markus.t.metzger@gmail.com
> Subject: Re: [PATCH 2/3] record-btrace, disas: omit pc prefix
>
> On Mon, 25 Feb 2013 17:15:16 +0100, markus.t.metzger@intel.com wrote:
> > From: Markus Metzger <markus.t.metzger@intel.com>
> >
> > Add a disassembly flag to omit the pc prefix and use it in the "record
> > instruction-history" command of record-btrace.
> >
> > The pc prefix would appear multiple times in the branch trace disassembly,
> > which is more confusing than helpful.
>
> I do not see it, moreover I find the output better without this patch:
Within a loop, you will see repeating => very frequently.
(gdb) rec inst -
0x00000000004006ec <_ZL4loopPv+8>: mov 0x200955(%rip),%rax # 0x601048 <_ZL6shared>
=> 0x00000000004006f3 <_ZL4loopPv+15>: add $0x1,%rax
0x00000000004006f7 <_ZL4loopPv+19>: mov %rax,0x20094a(%rip) # 0x601048 <_ZL6shared>
0x00000000004006fe <_ZL4loopPv+26>: jmp 0x4006ec <_ZL4loopPv+8>
0x00000000004006ec <_ZL4loopPv+8>: mov 0x200955(%rip),%rax # 0x601048 <_ZL6shared>
=> 0x00000000004006f3 <_ZL4loopPv+15>: add $0x1,%rax
0x00000000004006f7 <_ZL4loopPv+19>: mov %rax,0x20094a(%rip) # 0x601048 <_ZL6shared>
0x00000000004006fe <_ZL4loopPv+26>: jmp 0x4006ec <_ZL4loopPv+8>
0x00000000004006ec <_ZL4loopPv+8>: mov 0x200955(%rip),%rax # 0x601048 <_ZL6shared>
=> 0x00000000004006f3 <_ZL4loopPv+15>: add $0x1,%rax
(gdb)
[...]
> (gdb) record instruction-history
> warning: Recorded trace may be corrupted.
> warning: Recorded trace may be corrupted.
> warning: Recorded trace may be corrupted.
That's unexpected. If you can reproduce this, would you please send
me the reproducer so I can have a look at it?
[...]
Thanks,
Markus.
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052
next prev parent reply other threads:[~2013-02-28 7:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-25 16:15 [PATCH 0/3] target record-btrace markus.t.metzger
2013-02-25 16:16 ` [PATCH 3/3] doc, record: document record changes markus.t.metzger
2013-02-26 17:24 ` Eli Zaretskii
2013-03-01 14:07 ` Metzger, Markus T
2013-03-01 14:26 ` Eli Zaretskii
2013-03-01 14:48 ` Metzger, Markus T
2013-03-01 15:12 ` Eli Zaretskii
2013-03-01 15:21 ` Metzger, Markus T
2013-03-02 9:46 ` Eli Zaretskii
2013-02-25 16:16 ` [PATCH 1/3] record, btrace: add record-btrace target markus.t.metzger
2013-02-27 7:38 ` Jan Kratochvil
2013-02-27 19:43 ` Jan Kratochvil
2013-02-28 17:17 ` Metzger, Markus T
2013-03-01 9:26 ` Jan Kratochvil
2013-02-25 16:16 ` [PATCH 2/3] record-btrace, disas: omit pc prefix markus.t.metzger
2013-02-27 7:59 ` Jan Kratochvil
2013-02-28 7:45 ` Metzger, Markus T [this message]
2013-02-28 7:56 ` Jan Kratochvil
2013-02-28 8:45 ` Metzger, Markus T
2013-02-28 8:54 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A78C989F6D9628469189715575E55B2307B86928@IRSMSX102.ger.corp.intel.com \
--to=markus.t.metzger@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=markus.t.metzger@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox