RE: [PATCH 3/3] doc, record: document record changes

["Metzger, Markus T" <markus.t.metzger@intel.com>]

> -----Original Message-----
> From: Eli Zaretskii [mailto:eliz@gnu.org]
> Sent: Friday, March 01, 2013 4:12 PM


> > > > 1  void foo (void)
> > > > 2 {
> > > > 3    ...
> > > > 4    bar ();
> > > > 5    ...
> > > > 6  }
> > > >
> > > > When we record the execution of foo, there will be instructions for the
> > > > first ..., then instructions for bar, and then instructions for the second ....
> > > >
> > > > The "record function-call-history" will print:
> > > >   foo.c:1-4	foo (void)
> > > >   bar.c:8-12	bar (void)
> > > >   foo.c:5-6	foo (void
> > >
> > > This indicates that "record function-execution-history" might be a
> > > better name.  But in any case, weren't 'bar' and 'foo' called in this
> > > example?
> >
> > Yes, they were called.
> >
> > What I have problems with is that foo was called once but we print
> > two lines for foo, one for instructions before the call to bar and one
> > for instructions after the return from bar.
> >
> > Wouldn't "called" suggest that there be only one line for foo in the
> > above example?
> 
> Perhaps we should change our aspect angle and use this:
> 
>   "record function-call-history" prints the execution history at
>   function granularity.

OK.


> > In the documentation, there had been a @kindex show record memory-query.
> > I changed it to @kindex show record full memory-query.
> 
> OK, but there should be only one entry that begins with "@kindex show
> record full".

There were several entries that begin with "@kindex show record" and now
there are several entries that begin with "@kindex show record full".

When I fix this, do I need to reorder the documentation such that all the
"set record full" and all the "show record full" are listed together?

At the moment, corresponding set and show commands are grouped together.

To make things more interesting, there are "set/show record", "set/show
record full", and "set/show record btrace" sub-commands.

Regards,
Markus.
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052