From: Eli Zaretskii <eliz@gnu.org>
To: "Metzger, Markus T" <markus.t.metzger@intel.com>
Cc: jan.kratochvil@redhat.com, gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] doc, record: document record changes
Date: Fri, 01 Mar 2013 15:12:00 -0000 [thread overview]
Message-ID: <83sj4fupcf.fsf@gnu.org> (raw)
In-Reply-To: <A78C989F6D9628469189715575E55B2307B8748C@IRSMSX102.ger.corp.intel.com>
> From: "Metzger, Markus T" <markus.t.metzger@intel.com>
> CC: "jan.kratochvil@redhat.com" <jan.kratochvil@redhat.com>,
> "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
> Date: Fri, 1 Mar 2013 14:45:35 +0000
>
> > > 1 void foo (void)
> > > 2 {
> > > 3 ...
> > > 4 bar ();
> > > 5 ...
> > > 6 }
> > >
> > > When we record the execution of foo, there will be instructions for the
> > > first ..., then instructions for bar, and then instructions for the second ....
> > >
> > > The "record function-call-history" will print:
> > > foo.c:1-4 foo (void)
> > > bar.c:8-12 bar (void)
> > > foo.c:5-6 foo (void
> >
> > This indicates that "record function-execution-history" might be a
> > better name. But in any case, weren't 'bar' and 'foo' called in this
> > example?
>
> Yes, they were called.
>
> What I have problems with is that foo was called once but we print
> two lines for foo, one for instructions before the call to bar and one
> for instructions after the return from bar.
>
> Wouldn't "called" suggest that there be only one line for foo in the
> above example?
Perhaps we should change our aspect angle and use this:
"record function-call-history" prints the execution history at
function granularity.
> In the documentation, there had been a @kindex show record memory-query.
> I changed it to @kindex show record full memory-query.
OK, but there should be only one entry that begins with "@kindex show
record full".
next prev parent reply other threads:[~2013-03-01 15:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-25 16:15 [PATCH 0/3] target record-btrace markus.t.metzger
2013-02-25 16:16 ` [PATCH 3/3] doc, record: document record changes markus.t.metzger
2013-02-26 17:24 ` Eli Zaretskii
2013-03-01 14:07 ` Metzger, Markus T
2013-03-01 14:26 ` Eli Zaretskii
2013-03-01 14:48 ` Metzger, Markus T
2013-03-01 15:12 ` Eli Zaretskii [this message]
2013-03-01 15:21 ` Metzger, Markus T
2013-03-02 9:46 ` Eli Zaretskii
2013-02-25 16:16 ` [PATCH 1/3] record, btrace: add record-btrace target markus.t.metzger
2013-02-27 7:38 ` Jan Kratochvil
2013-02-27 19:43 ` Jan Kratochvil
2013-02-28 17:17 ` Metzger, Markus T
2013-03-01 9:26 ` Jan Kratochvil
2013-02-25 16:16 ` [PATCH 2/3] record-btrace, disas: omit pc prefix markus.t.metzger
2013-02-27 7:59 ` Jan Kratochvil
2013-02-28 7:45 ` Metzger, Markus T
2013-02-28 7:56 ` Jan Kratochvil
2013-02-28 8:45 ` Metzger, Markus T
2013-02-28 8:54 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sj4fupcf.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=markus.t.metzger@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox