From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15618 invoked by alias); 28 Feb 2013 07:03:38 -0000 Received: (qmail 15607 invoked by uid 22791); 28 Feb 2013 07:03:37 -0000 X-SWARE-Spam-Status: No, hits=-8.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mga02.intel.com (HELO mga02.intel.com) (134.134.136.20) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 28 Feb 2013 07:03:31 +0000 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 27 Feb 2013 23:03:29 -0800 X-ExtLoop1: 1 Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga001.jf.intel.com with ESMTP; 27 Feb 2013 23:03:28 -0800 Received: from irsmsx151.ger.corp.intel.com (163.33.192.59) by IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS) id 14.1.355.2; Thu, 28 Feb 2013 07:03:05 +0000 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.108]) by IRSMSX151.ger.corp.intel.com ([169.254.4.144]) with mapi id 14.01.0355.002; Thu, 28 Feb 2013 07:03:04 +0000 From: "Metzger, Markus T" To: Jan Kratochvil CC: "gdb-patches@sourceware.org" , "markus.t.metzger@gmail.com" Subject: RE: [PATCH 2/3] record-btrace, disas: omit pc prefix Date: Thu, 28 Feb 2013 07:45:00 -0000 Message-ID: References: <1361808917-16934-1-git-send-email-markus.t.metzger@intel.com> <1361808917-16934-3-git-send-email-markus.t.metzger@intel.com> <20130227075925.GA5003@host2.jankratochvil.net> In-Reply-To: <20130227075925.GA5003@host2.jankratochvil.net> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00724.txt.bz2 > -----Original Message----- > From: Jan Kratochvil [mailto:jan.kratochvil@redhat.com] > Sent: Wednesday, February 27, 2013 8:59 AM > To: Metzger, Markus T > Cc: gdb-patches@sourceware.org; markus.t.metzger@gmail.com > Subject: Re: [PATCH 2/3] record-btrace, disas: omit pc prefix >=20 > On Mon, 25 Feb 2013 17:15:16 +0100, markus.t.metzger@intel.com wrote: > > From: Markus Metzger > > > > Add a disassembly flag to omit the pc prefix and use it in the "record > > instruction-history" command of record-btrace. > > > > The pc prefix would appear multiple times in the branch trace disassemb= ly, > > which is more confusing than helpful. >=20 > I do not see it, moreover I find the output better without this patch: Within a loop, you will see repeating =3D> very frequently. (gdb) rec inst - 0x00000000004006ec <_ZL4loopPv+8>: mov 0x200955(%rip),%rax # 0= x601048 <_ZL6shared> =3D> 0x00000000004006f3 <_ZL4loopPv+15>: add $0x1,%rax 0x00000000004006f7 <_ZL4loopPv+19>: mov %rax,0x20094a(%rip) # = 0x601048 <_ZL6shared> 0x00000000004006fe <_ZL4loopPv+26>: jmp 0x4006ec <_ZL4loopPv+8> 0x00000000004006ec <_ZL4loopPv+8>: mov 0x200955(%rip),%rax # 0= x601048 <_ZL6shared> =3D> 0x00000000004006f3 <_ZL4loopPv+15>: add $0x1,%rax 0x00000000004006f7 <_ZL4loopPv+19>: mov %rax,0x20094a(%rip) # = 0x601048 <_ZL6shared> 0x00000000004006fe <_ZL4loopPv+26>: jmp 0x4006ec <_ZL4loopPv+8> 0x00000000004006ec <_ZL4loopPv+8>: mov 0x200955(%rip),%rax # 0= x601048 <_ZL6shared> =3D> 0x00000000004006f3 <_ZL4loopPv+15>: add $0x1,%rax (gdb) [...] > (gdb) record instruction-history > warning: Recorded trace may be corrupted. > warning: Recorded trace may be corrupted. > warning: Recorded trace may be corrupted. That's unexpected. If you can reproduce this, would you please send me the reproducer so I can have a look at it? [...] Thanks, Markus. Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052