Re: [PATCH 1/2] gcore: improve shell use

[Simon Marchi <simark@simark.ca>]

On 3/31/25 2:44 PM, Andreas Schwab wrote:
> On Mär 31 2025, Simon Marchi wrote:
> 
>> I actually can't figure out what this "if" does:
>>
>>     if [[ "$OPT" = "-" ]]; then
>> 	OPT="${OPTARG%%=*}"
>> 	OPTARG="${OPTARG#'$OPT'}"
>> 	OPTARG="${OPTARG#=}"
>>     fi
>>
>> Any idea?
> 
> I think this is supposed to handle the long options --help and
> --version.

Oh, right, looks like a nice hack to support long options, which getopts
doesn't appear to support officially.

I think that indeed the line doesn't work as intended then.  I hacked
gcore to print OPT and OPTARG.  I get:

    $ ./gcore --version
    OPT: version
    OPTARG: version

OPTARG should be empty here.  If I change

    OPTARG="${OPTARG#'$OPT'}"

to

    OPTARG="${OPTARG#"$OPT"}"

then I get:

    $ ./gcore --version
    OPT: version                                                                                             │
    OPTARG:

There is not long option that uses OPTARG, so this bug has no impact,
but we might as well fix it in this patch.

Simon