Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Keith Seitz <keiths@redhat.com>
To: Simon Marchi <simark@simark.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] gcore: improve shell use
Date: Wed, 2 Apr 2025 09:08:28 -0700	[thread overview]
Message-ID: <21809a83-d531-494e-8e4b-45a64b3360cb@redhat.com> (raw)
In-Reply-To: <9eb8f456-83dc-481f-8ec7-548230d0d789@simark.ca>

On 3/31/25 11:54 AM, Simon Marchi wrote:
> I think that indeed the line doesn't work as intended then.  I hacked
> gcore to print OPT and OPTARG.  I get:
> 
>      $ ./gcore --version
>      OPT: version
>      OPTARG: version
> 
> OPTARG should be empty here.  If I change
> 
>      OPTARG="${OPTARG#'$OPT'}"
> 
> to
> 
>      OPTARG="${OPTARG#"$OPT"}"
> 
> then I get:
> 
>      $ ./gcore --version
>      OPT: version                                                                                             │
>      OPTARG:
> 
> There is not long option that uses OPTARG, so this bug has no impact,
> but we might as well fix it in this patch.

Yes, I agree. My darn fingers still get confused between python quoting
and shell quoting.

Thank you for pursuing this,
Keith


  reply	other threads:[~2025-04-02 16:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-28 18:58 [PATCH 0/2] shell fixes for gcore, gdb-add-index Sam James
2025-03-28 18:58 ` [PATCH 1/2] gcore: improve shell use Sam James
2025-03-29 23:42   ` Keith Seitz
2025-03-31 18:26     ` Simon Marchi
2025-03-31 18:44       ` Andreas Schwab
2025-03-31 18:54         ` Simon Marchi
2025-04-02 16:08           ` Keith Seitz [this message]
2025-04-01 13:39   ` Tom Tromey
2025-04-02 16:15     ` Simon Marchi
2025-04-02 20:31       ` Tom Tromey
2025-03-28 18:58 ` [PATCH 2/2] gdb-add-index: fix shellcheck warnings Sam James
2025-03-29 23:42   ` Keith Seitz
2025-03-31 18:30     ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21809a83-d531-494e-8e4b-45a64b3360cb@redhat.com \
    --to=keiths@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox