From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4Mu5Aylh7Wd4LCQAWB0awg (envelope-from ) for ; Wed, 02 Apr 2025 12:09:13 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=IhotekRb; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0BF701E0C3; Wed, 2 Apr 2025 12:09:13 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B520E1E05C for ; Wed, 2 Apr 2025 12:09:12 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 62249385AC35 for ; Wed, 2 Apr 2025 16:09:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 62249385AC35 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=IhotekRb Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 101BD3858D26 for ; Wed, 2 Apr 2025 16:08:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 101BD3858D26 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 101BD3858D26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1743610115; cv=none; b=Kr5C5KVLGlVHD8YGaQx6/cBj3TWx2Q5lrGKSB6vnPnoCAnEb0mADlttAnp2MpxO9irVynwsxcUVVCZVoxij7v+zECFjys6nA+eWRgm32IqsktiQ1r/ANCjVpBsxJJ0dl4DUyzAdGxbF1Xu+2NEyWz2tehavWTCKkWJVWyo0NoTU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1743610115; c=relaxed/simple; bh=95cRWS4ECqofkwPBA4tfbsJkx4LUvsBBE95xaxmwIR8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=cy1HqIYEwN2LkzF7YC8cyIMNqjPPzubbPRXJR3yb/dFnNgTXLO/K5hk9RRr5ChAHAqPu3YJSQc5/V5Nf0O5RZPgqzoLE7LZvDJJ0L5FAK7VHPsYLl6vihKP1UGofy2+KiZRMXF7FRWLf68XwhkWuTbZ4R0Obz32wZ80HNxhPLXY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 101BD3858D26 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743610114; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=94t5WWFgWAoKgfrFykDo8yL4E2vsNWjNCiRvaOzFmbc=; b=IhotekRbrQX3l5Hi3FhFMHa3cHUBYqDZN2lp9hI0gfGcREP/ZIWBi8oUFsA17IR66wJNw4 E5sLInmnX+CgCgawmIR/7sdTeXwAX6bGCEHA1CFWibviMdfDACAdQOaAktB3UNaUOtTxNK a6LTANFK64TMuBAtmj/+2mrfIR9e/CE= Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-647-7AM_5xd3Np6ThdvGFw1n4w-1; Wed, 02 Apr 2025 12:08:32 -0400 X-MC-Unique: 7AM_5xd3Np6ThdvGFw1n4w-1 X-Mimecast-MFC-AGG-ID: 7AM_5xd3Np6ThdvGFw1n4w_1743610111 Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-ad50a3a9766so17611a12.0 for ; Wed, 02 Apr 2025 09:08:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743610111; x=1744214911; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=94t5WWFgWAoKgfrFykDo8yL4E2vsNWjNCiRvaOzFmbc=; b=PItkEYALZe1hwiwx1GEUQ13EVZTNANcosFBdSqVq4iPFza6ErXd94RNeRGy+wkODS6 K7Zxd3s8u/sZx/U+gwxnFBBTRZVc1JysENr+/GDOpl+DzrcsOScfasyoIyxkxx6qjL4S i0ukFgahi+xv1DhW9u5O8STEbxkxELDSqa1sAtMoe9hY5fhGLM2Lnr+1hGvff3aXXATa Dg4/Fi8I6UEtsA0fvk8Lcbo1rUUvYAM2veX8JjbvLUo50LTnveJlhXfMC5ShH954H9uD NDpoqFsfkoWPBzKxHCIPk8XEYnXYqJmlpvmYrHxWo55/fpWL7S0HgIg4no+45V9NZd77 ABwg== X-Gm-Message-State: AOJu0YzLua8aJu6sgA0j6862JhnhbOqh3qKVy29SOhBv7cWMQ5hQ89aG 1igJry40UNtyZw3393/ErBK4Z4lNFnytxHiNSy3mZBwGb+Zj7dF+s4FopVGiHx8FNtfU1NBwaNI dUWkvGiCk/LykJBSCNRF+B1ovhZlDP6mSkjKuTnLzvDR6e6MNl29HsAXfganuvTmQ/vM= X-Gm-Gg: ASbGncsBX9rBS22+EIzLY10dsTsssdc7S9KdZLs85QWnd71WsAwxJSizdTtYvxwdIKR xYJJp25+tinjfQW34tjoLDVfHsshavQJ28u99R6wQ/IBwWsls9JCmDbsXob71lAH80zFmmyi01C GvtZbe+POx8sazv0BoAmvKUrwwT3CedZLswCqZKblGdtWfxY+olmYAeUQOje9oR4YCkS+mJRMLf 2+apduFmvtoCxSEA5KDx77NWb3vXJJllqbilsX1lq64ntea7C4MHE9CYYWyr6hMXKkNBzKrDazo w/8riQM+KymxXbQQytyl X-Received: by 2002:a17:903:230d:b0:227:e82b:b585 with SMTP id d9443c01a7336-2296c6620c7mr37511785ad.20.1743610111224; Wed, 02 Apr 2025 09:08:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHYhRXYy0OqVzIN71pqT+ztNmvPcYQQ7oD1Ru89ptlF6O17I542IfiPNOFiSdABK2Ce7t2yqw== X-Received: by 2002:a17:903:230d:b0:227:e82b:b585 with SMTP id d9443c01a7336-2296c6620c7mr37511555ad.20.1743610110880; Wed, 02 Apr 2025 09:08:30 -0700 (PDT) Received: from [150.1.200.127] ([172.56.105.77]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73970e52306sm11131422b3a.83.2025.04.02.09.08.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Apr 2025 09:08:30 -0700 (PDT) Message-ID: <21809a83-d531-494e-8e4b-45a64b3360cb@redhat.com> Date: Wed, 2 Apr 2025 09:08:28 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] gcore: improve shell use To: Simon Marchi Cc: gdb-patches@sourceware.org References: <6be92d7ddcd426fd79a3fb9f44c49abea6e16aef.1743188332.git.sam@gentoo.org> <944054f1-6a59-4115-8340-95d399b931e2@redhat.com> <87a591vy39.fsf@igel.home> <9eb8f456-83dc-481f-8ec7-548230d0d789@simark.ca> From: Keith Seitz In-Reply-To: <9eb8f456-83dc-481f-8ec7-548230d0d789@simark.ca> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: XOYxf3YkumeL3OuamzEfXIYP0N9VPSYw21rY_2-p70k_1743610111 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/31/25 11:54 AM, Simon Marchi wrote: > I think that indeed the line doesn't work as intended then. I hacked > gcore to print OPT and OPTARG. I get: > > $ ./gcore --version > OPT: version > OPTARG: version > > OPTARG should be empty here. If I change > > OPTARG="${OPTARG#'$OPT'}" > > to > > OPTARG="${OPTARG#"$OPT"}" > > then I get: > > $ ./gcore --version > OPT: version │ > OPTARG: > > There is not long option that uses OPTARG, so this bug has no impact, > but we might as well fix it in this patch. Yes, I agree. My darn fingers still get confused between python quoting and shell quoting. Thank you for pursuing this, Keith