From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>, Sam James <sam@gentoo.org>,
gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] gcore: improve shell use
Date: Wed, 02 Apr 2025 14:31:18 -0600 [thread overview]
Message-ID: <877c425mqx.fsf@tromey.com> (raw)
In-Reply-To: <b9e2ed55-f72b-4d24-a4c6-bf3e1f4b06b3@simark.ca> (Simon Marchi's message of "Wed, 2 Apr 2025 12:15:37 -0400")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
Simon> On 4/1/25 9:39 AM, Tom Tromey wrote:
>>>>>>> "Sam" == Sam James <sam@gentoo.org> writes:
>>
Sam> * Use bash tests, i.e. '[[' and ']]', instead of POSIX '[' and ']' or
Sam> 'test' which have their own pitfalls, given gcore has a bash shebang already.
>>
>> Do we want this to require bash or should it instead just use sh?
Simon> gcore already requires bash as we speak, which IMO is reasonable.
I understand that it requires it presently. I'm asking whether the
script should require bash.
I tend to think requiring bash is an artifact of its history, coming
from a Linux vendor. But perhaps bash isn't really required and we
could make it portable.
thanks,
Tom
next prev parent reply other threads:[~2025-04-02 20:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-28 18:58 [PATCH 0/2] shell fixes for gcore, gdb-add-index Sam James
2025-03-28 18:58 ` [PATCH 1/2] gcore: improve shell use Sam James
2025-03-29 23:42 ` Keith Seitz
2025-03-31 18:26 ` Simon Marchi
2025-03-31 18:44 ` Andreas Schwab
2025-03-31 18:54 ` Simon Marchi
2025-04-02 16:08 ` Keith Seitz
2025-04-01 13:39 ` Tom Tromey
2025-04-02 16:15 ` Simon Marchi
2025-04-02 20:31 ` Tom Tromey [this message]
2025-03-28 18:58 ` [PATCH 2/2] gdb-add-index: fix shellcheck warnings Sam James
2025-03-29 23:42 ` Keith Seitz
2025-03-31 18:30 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877c425mqx.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=sam@gentoo.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox