Re: [PATCH 1/2] gcore: improve shell use

[Keith Seitz <keiths@redhat.com>]

Hi,

On 3/28/25 11:58 AM, Sam James wrote:
> * Use bash tests, i.e. '[[' and ']]', instead of POSIX '[' and ']' or
>    'test' which have their own pitfalls, given gcore has a bash shebang already.
> 
> * Use $() subshell syntax rather than `backticks`.

Nice. I didn't actually know that '[['/']]' was preferred. I'll have
to remember that.

> ---
>   gdb/gcore-1.in | 22 +++++++++++-----------
>   1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/gdb/gcore-1.in b/gdb/gcore-1.in
> index c0979a51db3..edd807b86dc 100644
> --- a/gdb/gcore-1.in
> +++ b/gdb/gcore-1.in
> @@ -139,14 +139,14 @@ if test "x$binary_path" = x. ; then
>       # The gcore script was not found in ".", which means the script
>       # was called from somewhere else in $PATH by "sh gcore".
>       # Extract the correct path now.
> -    binary_path_from_env=`which "$0"`
> -    binary_path=`dirname "$binary_path_from_env"`
> +    binary_path_from_env=$(which "$0")
> +    binary_path=$(dirname "$binary_path_from_env")

This uses 'which', and we've (downstream distros) run into issues
with this and package dependencies. Since this strictly bash,
can we use "command -v" here instead?

Thank you for doing this.

Reviewed-By: Keith Seitz <keiths@redhat.com>

Keith

>     fi
>   fi
>   
>   # Check if the GDB binary is in the expected path.  If not, just
>   # quit with a message.
> -if [ ! -f "$binary_path/@GDB_TRANSFORM_NAME@" ]; then
> +if [[ ! -f "$binary_path/@GDB_TRANSFORM_NAME@" ]]; then
>     echo "gcore: GDB binary (${binary_path}/@GDB_TRANSFORM_NAME@) not found"
>     exit 1
>   fi