From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id F+xFK96F6GfaFx8AWB0awg (envelope-from ) for ; Sat, 29 Mar 2025 19:44:30 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=fxZnllq2; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A06B01E0C3; Sat, 29 Mar 2025 19:44:30 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B43171E0C0 for ; Sat, 29 Mar 2025 19:44:29 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 48C623858D29 for ; Sat, 29 Mar 2025 23:44:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 48C623858D29 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=fxZnllq2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id B726F3858D29 for ; Sat, 29 Mar 2025 23:42:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B726F3858D29 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B726F3858D29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1743291775; cv=none; b=q7LwBWSiaV93WgYLxX2TQHerbI3WbBLeHFNyXizaM7aD5qYY+JTcV8efl+ISttvTAp2OSiiOkabmCVYWeeLN6N0DpIAysoH4UKQB8PnUzCsunjvELfyFlqhH+5jLFmnP67FUNLqflt0HKUXGN77IxcKhuC/STNozLFT1zdw/mP0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1743291775; c=relaxed/simple; bh=4ozFGS22/V6drrulWCyqV1KmCE2TyMuC7mXFY7xRxO0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=IReqPGTRgzB7ZZHxcHWtguSYytgpNS1X3aDK3E8VXUB0NDjxLW4H7BomEBKDnXk9p2BgW5Mjc+2MHba+aKIJFdLF92DSj6/nZJ8KsWZqXsqn4hB32vIThS8n+yKrNfNpdoyBzc/RqHaHOu6u5+2tMkM26miiAAC2bAKK5KRQ5u8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B726F3858D29 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743291775; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+xk+i6IMqjHKRO6R1tThpr7kLJDnGraAlN+8QeZxxFk=; b=fxZnllq2UFYO+3eKSSqiXAW3bDE+tNgv68xlN9QBlWVGH+FCYcGz8jGx9zXuWE/v6S9mzu eFzFlnMqgdnZzwSUyRhZUJM1axZZsBDA8qVle4XAjCmBHjAmx3h58Ii6jmvPZI7A1QDZ3i LIrtMPVLrhGd70BhSewxqeOduydMDww= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-446-SSTD3oKgPjmmqWBz1Vzi-w-1; Sat, 29 Mar 2025 19:42:53 -0400 X-MC-Unique: SSTD3oKgPjmmqWBz1Vzi-w-1 X-Mimecast-MFC-AGG-ID: SSTD3oKgPjmmqWBz1Vzi-w_1743291773 Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-2ff64898e2aso6869103a91.1 for ; Sat, 29 Mar 2025 16:42:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743291773; x=1743896573; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+xk+i6IMqjHKRO6R1tThpr7kLJDnGraAlN+8QeZxxFk=; b=jETrs3nzTgb3k/iLMZcWVsdiiRaA/mZvilMMQNa+nczUCmFZ4nf8BiRbYOVha8tASg D5btk+BlRccH27kkqDSRhWMtCuwo/R+tSDmynzne+6RMWqdmRpsNabnhcounWdVluXdS nRJsGLoa9uRzCU8c9TdJYLLrHE/21STU5CjdhYwy43aXjT8bdNK59prf02TUOa4HpXpM v4eqv15/VpaYS0MO8ZXKzTE4SIZdqqHm3lYe4TE21nM1otlSugB8KLQIQIwqLylm5QEs TDHMaS0fVNssBb00Aon41FJNeBqU281xlAeWXSPrW+mg/ityg2jTEiqpuuzCsgCp51xW x8lw== X-Forwarded-Encrypted: i=1; AJvYcCUmEmDe8iHeEvWdDQGhc3fvZflC63N9K+wgBbq3vdIjjFKPhW4p8lzryJTk2a8AZtYglX9wiTck2kE5Jw==@sourceware.org X-Gm-Message-State: AOJu0YwHcKFMqY/EF5r8aoFmLBEhDoNYeZY8iPuIN6vw5gtandf8KVBu y/nVFdIvC9hgrAR0P8EqbgFvn6/jDj3DOLrG13JNuzm+cYpw8C2uLg6mTITdu3LL1vDNzI3E3h8 pCDYWqJ5+s+3Ilyie29AHFihbdmsT/G5/G5Bm6QHYLgt7EmnVVa2PsiI6U+s= X-Gm-Gg: ASbGncu75FZiiKFoJud4t+4wL+88vNmdgEGkSyElh17i5vc7R+agXkr5d79EkS8EczY +8g5jt4S4yPG5+hgiXmiVxLoVV1LAgYz3PknswJ8Fostk9K6j9KxRa2EwmzjmCKi5vDdzjRX+ab 1LVHDatBGbVqkUElB/zPd/f8DSZdRR6bxv9R3IM304nRHR+Djihvvbzt+DMZ1n43OMfbSrxAKQ0 /D3GhdRsBi6CreOzmfyDuSiTZ3tTWhzkSLxyUwrn2nVdIp2wMU+2mDoIys4xUM8sfYuUPrmakcn zi2YtgDvp2VTThZml7+n X-Received: by 2002:a05:6a00:3a07:b0:736:4c3d:2cba with SMTP id d2e1a72fcca58-7397271c499mr12484264b3a.9.1743291772904; Sat, 29 Mar 2025 16:42:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGOPX95zUf7ymcwxG0LUf83bnrpgx8cM9Emy+czvC5xcmD2/WVTThf5wocrsuV5dwOtAB3H9w== X-Received: by 2002:a05:6a00:3a07:b0:736:4c3d:2cba with SMTP id d2e1a72fcca58-7397271c499mr12484244b3a.9.1743291772564; Sat, 29 Mar 2025 16:42:52 -0700 (PDT) Received: from [150.1.200.127] ([172.56.105.77]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73970deef04sm4184911b3a.1.2025.03.29.16.42.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 29 Mar 2025 16:42:52 -0700 (PDT) Message-ID: <944054f1-6a59-4115-8340-95d399b931e2@redhat.com> Date: Sat, 29 Mar 2025 16:42:50 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] gcore: improve shell use To: Sam James , gdb-patches@sourceware.org References: <6be92d7ddcd426fd79a3fb9f44c49abea6e16aef.1743188332.git.sam@gentoo.org> From: Keith Seitz In-Reply-To: <6be92d7ddcd426fd79a3fb9f44c49abea6e16aef.1743188332.git.sam@gentoo.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: A_tLKI-g--aLLneOWL5ws4_0-yOIHWHdmtFCAUEQ0PI_1743291773 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi, On 3/28/25 11:58 AM, Sam James wrote: > * Use bash tests, i.e. '[[' and ']]', instead of POSIX '[' and ']' or > 'test' which have their own pitfalls, given gcore has a bash shebang already. > > * Use $() subshell syntax rather than `backticks`. Nice. I didn't actually know that '[['/']]' was preferred. I'll have to remember that. > --- > gdb/gcore-1.in | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/gdb/gcore-1.in b/gdb/gcore-1.in > index c0979a51db3..edd807b86dc 100644 > --- a/gdb/gcore-1.in > +++ b/gdb/gcore-1.in > @@ -139,14 +139,14 @@ if test "x$binary_path" = x. ; then > # The gcore script was not found in ".", which means the script > # was called from somewhere else in $PATH by "sh gcore". > # Extract the correct path now. > - binary_path_from_env=`which "$0"` > - binary_path=`dirname "$binary_path_from_env"` > + binary_path_from_env=$(which "$0") > + binary_path=$(dirname "$binary_path_from_env") This uses 'which', and we've (downstream distros) run into issues with this and package dependencies. Since this strictly bash, can we use "command -v" here instead? Thank you for doing this. Reviewed-By: Keith Seitz Keith > fi > fi > > # Check if the GDB binary is in the expected path. If not, just > # quit with a message. > -if [ ! -f "$binary_path/@GDB_TRANSFORM_NAME@" ]; then > +if [[ ! -f "$binary_path/@GDB_TRANSFORM_NAME@" ]]; then > echo "gcore: GDB binary (${binary_path}/@GDB_TRANSFORM_NAME@) not found" > exit 1 > fi