From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EImiBbXl6meqhSEAWB0awg (envelope-from ) for ; Mon, 31 Mar 2025 14:57:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1743447477; bh=AIo/ftwdWOfxnWffmR+0lphEgNHEOIZLL6jALwoKH18=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=kZZSXKcgmQXsU0GA6htIrf+hu9/dzgcTNJFRIF31maF1ksc8wiqSi2LhJi9EBRC6A HSSgi+vn13sRXJW/bZCDNHHYhNV9TSQvs48aYNykPKT4PAOMQIzmWvzFQfIMGPRbeW 3bBceueE1G4GE5lyz1625ALSPVnkaiIVZ3NDvyUY= Received: by simark.ca (Postfix, from userid 112) id 124FF1E0C3; Mon, 31 Mar 2025 14:57:57 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=knMIv6lF; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=tw4xXa+a; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6A8541E0C0 for ; Mon, 31 Mar 2025 14:57:56 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1A48E38460A3 for ; Mon, 31 Mar 2025 18:57:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1A48E38460A3 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=knMIv6lF; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=tw4xXa+a Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id CE3FC3849789 for ; Mon, 31 Mar 2025 18:54:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CE3FC3849789 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CE3FC3849789 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1743447277; cv=none; b=DMSXeOY4oLZEyx68zP9mDrRatcaQ3Ys9Z9Ssj2wtLG9czJB+3b4Ih+r/MvSSCtQqBjf1w04Z+pVjsaAqqeKDqNWGkXvll2/XK5RDvY15dFUtdOK+1A+vXQlKc3pbmyXQwZb+QLHVwKZNCuPk7lSC4AUyxuNK9hEvyTw9hb11GT8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1743447277; c=relaxed/simple; bh=AIo/ftwdWOfxnWffmR+0lphEgNHEOIZLL6jALwoKH18=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=q6NG5DZIrCT08pH+5XTCaPiEwhHtG2CpJ07RC8RGFJ4XTALTaSJlIeYfUy11KRgSv3eRrjtTTHW8ouXQhX+EZ335OJv0i2fPWJ7vHJgKrD0yFu96642Qa3dzAiLc9nK5Kb5y7u4dAjD/7RTl1hUS6QSCePulzRclN4D5VmuuRFI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CE3FC3849789 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1743447277; bh=AIo/ftwdWOfxnWffmR+0lphEgNHEOIZLL6jALwoKH18=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=knMIv6lF4wZ6BJrU05zlC5S45Wtx95BKQNUkV5CAju5mjbkf0zpwd4RV61B11bdQw ZIvXBg0nGTlJ2NOxvlDeRvtqvzhXgEBkpRBiWjUv7c7nBomzHlHk54j4qFxFSfBxbZ f7RpBmqBFPTJ7VyDUIRisspnNfmR//ATnE4C43Vg= Received: by simark.ca (Postfix, from userid 112) id 792381E114; Mon, 31 Mar 2025 14:54:37 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1743447275; bh=AIo/ftwdWOfxnWffmR+0lphEgNHEOIZLL6jALwoKH18=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=tw4xXa+avdBr7BhqCwMlyQ0w8G63/TsWydgZtZL8225qULtxPvJ66oTy8yViYkLz5 0Mb4c7BOt5ILGiTnpMGf7HlFbc73GnT1TBc+wsPzPcBIyJOaUAkGpgOTWEbcjKyBw7 2VqAekiA/jGOaDM6n9lJ7EbGYxSlvBgG+4VaxWAg= Received: from [172.16.0.192] (96-127-217-162.qc.cable.ebox.net [96.127.217.162]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 4A8F51E0C0; Mon, 31 Mar 2025 14:54:35 -0400 (EDT) Message-ID: <9eb8f456-83dc-481f-8ec7-548230d0d789@simark.ca> Date: Mon, 31 Mar 2025 14:54:34 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] gcore: improve shell use To: Andreas Schwab Cc: Keith Seitz , Sam James , gdb-patches@sourceware.org References: <6be92d7ddcd426fd79a3fb9f44c49abea6e16aef.1743188332.git.sam@gentoo.org> <944054f1-6a59-4115-8340-95d399b931e2@redhat.com> <87a591vy39.fsf@igel.home> Content-Language: fr From: Simon Marchi In-Reply-To: <87a591vy39.fsf@igel.home> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/31/25 2:44 PM, Andreas Schwab wrote: > On Mär 31 2025, Simon Marchi wrote: > >> I actually can't figure out what this "if" does: >> >> if [[ "$OPT" = "-" ]]; then >> OPT="${OPTARG%%=*}" >> OPTARG="${OPTARG#'$OPT'}" >> OPTARG="${OPTARG#=}" >> fi >> >> Any idea? > > I think this is supposed to handle the long options --help and > --version. Oh, right, looks like a nice hack to support long options, which getopts doesn't appear to support officially. I think that indeed the line doesn't work as intended then. I hacked gcore to print OPT and OPTARG. I get: $ ./gcore --version OPT: version OPTARG: version OPTARG should be empty here. If I change OPTARG="${OPTARG#'$OPT'}" to OPTARG="${OPTARG#"$OPT"}" then I get: $ ./gcore --version OPT: version │ OPTARG: There is not long option that uses OPTARG, so this bug has no impact, but we might as well fix it in this patch. Simon