From: Luis Machado <luis.machado@linaro.org>
To: Carlo Bramini <carlo.bramix@libero.it>, gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: Re: [PATCH] Aarch64-SIM: BLR opcode does not support XLR register properly.
Date: Wed, 05 Feb 2020 11:39:00 -0000 [thread overview]
Message-ID: <9c6afb97-dabc-3d2f-4980-db387930a8e6@linaro.org> (raw)
In-Reply-To: <2054623523.792939.1580901671145@mail1.libero.it>
Hi Carlo,
Thanks for the patch.
I'd include just the fix itself and not any other cosmetic changes to
the code, like moving/removing return statements. The statements are
useless, but it makes the patch cleaner that way.
It would also make it clear it is a reasonably obvious fix, which can be
pushed without a FSF assignment. Though it would be nice to have one in
place for further contributions.
Other than that, it is missing a ChangeLog entry, but it is not a big
deal for this particular change as one can quickly write one.
Luis
On 2/5/20 8:21 AM, Carlo Bramini wrote:
> After a suggestion received at your bugzilla, I'm posting here a patch. Detailed explanation can be found here:
>
> https://sourceware.org/bugzilla/show_bug.cgi?id=25318
>
> Thank you very much for your time and your support.
> Sincerely.
>
next prev parent reply other threads:[~2020-02-05 11:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 11:21 Carlo Bramini
2020-02-05 11:39 ` Luis Machado [this message]
2020-02-05 17:14 ` Carlo Bramini
2020-02-05 17:25 ` Carlo Bramini
2020-02-06 22:59 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c6afb97-dabc-3d2f-4980-db387930a8e6@linaro.org \
--to=luis.machado@linaro.org \
--cc=carlo.bramix@libero.it \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox