From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92862 invoked by alias); 5 Feb 2020 11:39:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92837 invoked by uid 89); 5 Feb 2020 11:39:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=posting, HX-Languages-Length:902, 25318, sincerely X-HELO: mail-wr1-f66.google.com Received: from mail-wr1-f66.google.com (HELO mail-wr1-f66.google.com) (209.85.221.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Feb 2020 11:39:37 +0000 Received: by mail-wr1-f66.google.com with SMTP id z9so2272135wrs.10 for ; Wed, 05 Feb 2020 03:39:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:cc:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=vBov0uBLIhB8Nd9NZJIAdv0YWb3rHIsDsXA0Ww0Q00E=; b=l4TdeCcYDstMbfIImZIKxA7B8YFuOEr8vMU035y95CSHN6VQ6c3wcPAAAYvbSicutf DpDjwQE3bZw3GqixRTghv1DReszY7DVVwDwLZf6zkWyBXut3IxO9hUKVeVs7V0tmJoM+ 5N+Z+mk/FKyHo/aijA/TpWPXrjgKFbigWRhP4jE+Mgce6+8PznTGarCy9hqzrx8l5ubF hrvzo6b3LCbizVra1H7qOxs7JiWxTdUS1pnE6zPFfxtovOD+sBHQaqVcoaiHSMb5sjD7 HvSchyZxvQ6Tviyd2LDjN9gVxFUFgWg5xkod4xakkn5BfnPhOqwzqQHS4rrnsiVhcZxL BP0A== Return-Path: Received: from [10.10.0.24] ([94.107.206.26]) by smtp.gmail.com with ESMTPSA id a8sm8207700wmc.20.2020.02.05.03.39.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Feb 2020 03:39:34 -0800 (PST) Subject: Re: [PATCH] Aarch64-SIM: BLR opcode does not support XLR register properly. To: Carlo Bramini , gdb-patches@sourceware.org References: <2054623523.792939.1580901671145@mail1.libero.it> From: Luis Machado Cc: Simon Marchi Message-ID: <9c6afb97-dabc-3d2f-4980-db387930a8e6@linaro.org> Date: Wed, 05 Feb 2020 11:39:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <2054623523.792939.1580901671145@mail1.libero.it> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00093.txt.bz2 Hi Carlo, Thanks for the patch. I'd include just the fix itself and not any other cosmetic changes to the code, like moving/removing return statements. The statements are useless, but it makes the patch cleaner that way. It would also make it clear it is a reasonably obvious fix, which can be pushed without a FSF assignment. Though it would be nice to have one in place for further contributions. Other than that, it is missing a ChangeLog entry, but it is not a big deal for this particular change as one can quickly write one. Luis On 2/5/20 8:21 AM, Carlo Bramini wrote: > After a suggestion received at your bugzilla, I'm posting here a patch. Detailed explanation can be found here: > > https://sourceware.org/bugzilla/show_bug.cgi?id=25318 > > Thank you very much for your time and your support. > Sincerely. >