Re: [PATCH] Aarch64-SIM: BLR opcode does not support XLR register properly.

Luis Machado
2020-02-05T11:39:40Z

Hi Carlo,

Thanks for the patch.

I'd include just the fix itself and not any other cosmetic changes to
the code, like moving/removing return statements. The statements are
useless, but it makes the patch cleaner that way.

It would also make it clear it is a reasonably obvious fix, which can be
pushed without a FSF assignment. Though it would be nice to have one in
place for further contributions.

Other than that, it is missing a ChangeLog entry, but it is not a big
deal for this particular change as one can quickly write one.

Luis

On 2/5/20 8:21 AM, Carlo Bramini wrote:
> After a suggestion received at your bugzilla, I'm posting here a patch. Detailed explanation can be found here:
>
> https://sourceware.org/bugzilla/show_bug.cgi?id=25318
>
> Thank you very much for your time and your support.
> Sincerely.
>