From: Simon Marchi <simark@simark.ca>
To: Alan Hayward <Alan.Hayward@arm.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: nd <nd@arm.com>
Subject: Re: [PATCH v2 1/5] Arm: Add read_description read funcs and use in GDB
Date: Thu, 11 Jul 2019 14:19:00 -0000 [thread overview]
Message-ID: <9b29cdf4-5815-19ec-bfed-7c623d5f6c55@simark.ca> (raw)
In-Reply-To: <20190711134436.47896-2-alan.hayward@arm.com>
On 2019-07-11 9:46 a.m., Alan Hayward wrote:
> Switch the Arm target to get target descriptions via arm_read_description
> and aarch32_read_description, in the same style as other feature targets.
> Add an enum to specify the different types - this will also be of use to
> gdbserver in a later patch.
>
> Under the hood return the same existing pre-feature target descriptions.
>
> Note: This commit will break the AArch64 gdbserver build.
Sorry for spamming you, one last thing :)
I forgot to ask you, what is it in this patch that is breaking the AArch64
gdbserver build in this? And what would it take for you not to break it?
We generally try to keep things building at each commit, so I'd just like
a bit more justifications about why it's worth breaking it here, rather than
doing the necessary work to keep it building.
Simon
next prev parent reply other threads:[~2019-07-11 14:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 13:45 [PATCH v2 0/5] Arm: Use feature target descriptions Alan Hayward
2019-07-11 13:46 ` [PATCH v2 2/5] " Alan Hayward
2019-07-11 13:46 ` [PATCH v2 1/5] Arm: Add read_description read funcs and use in GDB Alan Hayward
2019-07-11 13:56 ` Simon Marchi
2019-07-11 13:58 ` Simon Marchi
2019-07-11 18:04 ` Alan Hayward
2019-07-11 14:19 ` Simon Marchi [this message]
2019-07-11 13:46 ` [PATCH v2 5/5] Arm: Remove unused feature files and tests Alan Hayward
2019-07-11 13:46 ` [PATCH v2 4/5] Arm: Use read_description funcs in gdbserver Alan Hayward
2019-07-11 14:35 ` Simon Marchi
2019-07-11 13:46 ` [PATCH v2 3/5] Arm: Add xml unit tests Alan Hayward
2019-07-19 15:08 ` [PATCH v2 0/5] Arm: Use feature target descriptions Alan Hayward
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b29cdf4-5815-19ec-bfed-7c623d5f6c55@simark.ca \
--to=simark@simark.ca \
--cc=Alan.Hayward@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox