From: Alan Hayward <Alan.Hayward@arm.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: nd <nd@arm.com>, Alan Hayward <Alan.Hayward@arm.com>
Subject: [PATCH v2 0/5] Arm: Use feature target descriptions
Date: Thu, 11 Jul 2019 13:45:00 -0000 [thread overview]
Message-ID: <20190711134436.47896-1-alan.hayward@arm.com> (raw)
Version 2. First two patches from the original set have been pushed.
1 and 4 are updated as per review comments.
Otherwise identical. Will push mid next week if there are no more comments.
This set of patches is a result of me trying to figure out exactly what
is supported for Arm. It moves Arm over to using feature target descriptions,
simplifying the confusion of xml files in the features/arm/ directory.
In addition it helps to further separate out AArch32.
There are zero functional changes made by this series. The intention is
that all Arm target descriptions are identical before and after the series.
All quirks that might seem odd (for example, the Arm with NEON creates a
vfp3 feature and then a blank neon feature) have been preserved. One of the
patches adds tests to prove the new target descriptions are identical. The
final patch then removes these tests (as they block the removal of the xml
files).
One of the patches breaks the AArch64 gdbserver build, but it is fixed in
the following patch. Preventing this would have meant including additional
unused functionality, and then removing again.
Code has been tested with AArch32, Armv7, and X86 target-all builds. I don't
have every Arm target to test this on, but the xml tests should alleviate any
issue.
Alan Hayward (5):
Arm: Add read_description read funcs and use in GDB
Arm: Use feature target descriptions
Arm: Add xml unit tests
Arm: Use read_description funcs in gdbserver
Arm: Remove unused feature files and tests
gdb/Makefile.in | 5 ++
gdb/aarch32-tdep.c | 33 +++++++++
gdb/aarch32-tdep.h | 25 +++++++
gdb/aarch64-linux-nat.c | 6 +-
gdb/arch/aarch32.c | 43 +++++++++++
gdb/arch/aarch32.h | 27 +++++++
gdb/arch/arm.c | 84 ++++++++++++++++++++++
gdb/arch/arm.h | 27 +++++++
gdb/arm-fbsd-tdep.c | 12 ++--
gdb/arm-linux-nat.c | 11 +--
gdb/arm-linux-tdep.c | 11 +--
gdb/arm-tdep.c | 65 +++++++++++------
gdb/arm-tdep.h | 12 ++--
gdb/configure.tgt | 8 ++-
gdb/features/arm/arm-with-iwmmxt.c | 83 ---------------------
gdb/features/arm/arm-with-iwmmxt.xml | 13 ----
gdb/features/arm/arm-with-m-fpa-layout.c | 46 ------------
gdb/features/arm/arm-with-m-fpa-layout.xml | 46 ------------
gdb/features/arm/arm-with-m-vfp-d16.c | 56 ---------------
gdb/features/arm/arm-with-m-vfp-d16.xml | 14 ----
gdb/features/arm/arm-with-m.c | 37 ----------
gdb/features/arm/arm-with-m.xml | 12 ----
gdb/features/arm/arm-with-neon.c | 74 -------------------
gdb/features/arm/arm-with-neon.xml | 14 ----
gdb/features/arm/arm-with-vfpv2.c | 56 ---------------
gdb/features/arm/arm-with-vfpv2.xml | 13 ----
gdb/features/arm/arm-with-vfpv3.c | 72 -------------------
gdb/features/arm/arm-with-vfpv3.xml | 13 ----
gdb/gdbserver/configure.srv | 22 ++----
gdb/gdbserver/linux-aarch32-low.c | 2 -
gdb/gdbserver/linux-aarch32-low.h | 2 -
gdb/gdbserver/linux-aarch32-tdesc.c | 46 ++++++++++++
gdb/gdbserver/linux-aarch32-tdesc.h | 29 ++++++++
gdb/gdbserver/linux-aarch64-low.c | 3 +-
gdb/gdbserver/linux-arm-low.c | 77 ++++++++++----------
gdb/gdbserver/linux-arm-tdesc.c | 62 ++++++++++++++++
gdb/gdbserver/linux-arm-tdesc.h | 29 ++++++++
37 files changed, 532 insertions(+), 658 deletions(-)
create mode 100644 gdb/aarch32-tdep.c
create mode 100644 gdb/aarch32-tdep.h
create mode 100644 gdb/arch/aarch32.c
create mode 100644 gdb/arch/aarch32.h
delete mode 100644 gdb/features/arm/arm-with-iwmmxt.c
delete mode 100644 gdb/features/arm/arm-with-iwmmxt.xml
delete mode 100644 gdb/features/arm/arm-with-m-fpa-layout.c
delete mode 100644 gdb/features/arm/arm-with-m-fpa-layout.xml
delete mode 100644 gdb/features/arm/arm-with-m-vfp-d16.c
delete mode 100644 gdb/features/arm/arm-with-m-vfp-d16.xml
delete mode 100644 gdb/features/arm/arm-with-m.c
delete mode 100644 gdb/features/arm/arm-with-m.xml
delete mode 100644 gdb/features/arm/arm-with-neon.c
delete mode 100644 gdb/features/arm/arm-with-neon.xml
delete mode 100644 gdb/features/arm/arm-with-vfpv2.c
delete mode 100644 gdb/features/arm/arm-with-vfpv2.xml
delete mode 100644 gdb/features/arm/arm-with-vfpv3.c
delete mode 100644 gdb/features/arm/arm-with-vfpv3.xml
create mode 100644 gdb/gdbserver/linux-aarch32-tdesc.c
create mode 100644 gdb/gdbserver/linux-aarch32-tdesc.h
create mode 100644 gdb/gdbserver/linux-arm-tdesc.c
create mode 100644 gdb/gdbserver/linux-arm-tdesc.h
--
2.20.1 (Apple Git-117)
next reply other threads:[~2019-07-11 13:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 13:45 Alan Hayward [this message]
2019-07-11 13:46 ` [PATCH v2 2/5] " Alan Hayward
2019-07-11 13:46 ` [PATCH v2 1/5] Arm: Add read_description read funcs and use in GDB Alan Hayward
2019-07-11 13:56 ` Simon Marchi
2019-07-11 13:58 ` Simon Marchi
2019-07-11 18:04 ` Alan Hayward
2019-07-11 14:19 ` Simon Marchi
2019-07-11 13:46 ` [PATCH v2 5/5] Arm: Remove unused feature files and tests Alan Hayward
2019-07-11 13:46 ` [PATCH v2 3/5] Arm: Add xml unit tests Alan Hayward
2019-07-11 13:46 ` [PATCH v2 4/5] Arm: Use read_description funcs in gdbserver Alan Hayward
2019-07-11 14:35 ` Simon Marchi
2019-07-19 15:08 ` [PATCH v2 0/5] Arm: Use feature target descriptions Alan Hayward
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190711134436.47896-1-alan.hayward@arm.com \
--to=alan.hayward@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox