From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17679 invoked by alias); 11 Jul 2019 13:45:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17651 invoked by uid 89); 11 Jul 2019 13:45:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-16.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: EUR03-DB5-obe.outbound.protection.outlook.com Received: from mail-eopbgr40074.outbound.protection.outlook.com (HELO EUR03-DB5-obe.outbound.protection.outlook.com) (40.107.4.74) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Jul 2019 13:45:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=81YSlIP7WzxWfcvsYCXNf5fJdAJCW4/vyLUUTwB30t0=; b=cr27CcJh2jikgkUx1jdVSRi2us6eTTioFXxhBmjYkvEq0C/nf/kXQ36mYYyy+BuiRLZkD0biL8mBve9xfWxpKwZs7pOmtjDw86rFLe6JLEHiVlhtYlD6oGsB6tpZMuGSpDpGfmZXuKlxuAG6I8SXIC+dJm6yJN1WqagmilXFijQ= Received: from VI1PR0802CA0006.eurprd08.prod.outlook.com (2603:10a6:800:aa::16) by AM5PR0801MB1844.eurprd08.prod.outlook.com (2603:10a6:203:39::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2052.18; Thu, 11 Jul 2019 13:45:27 +0000 Received: from DB5EUR03FT023.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e0a::205) by VI1PR0802CA0006.outlook.office365.com (2603:10a6:800:aa::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2052.18 via Frontend Transport; Thu, 11 Jul 2019 13:45:27 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;sourceware.org; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT023.mail.protection.outlook.com (10.152.20.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2052.18 via Frontend Transport; Thu, 11 Jul 2019 13:45:26 +0000 Received: ("Tessian outbound 96ba4cc141ab:v24"); Thu, 11 Jul 2019 13:45:26 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 7cfc3d9bccd59627 X-CR-MTA-TID: 64aa7808 Received: from a2decac9e58c.1 (cr-mta-lb-1.cr-mta-net [104.47.9.59]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id CC0ABB92-8A88-4388-BE4B-9C389668160D.1; Thu, 11 Jul 2019 13:45:20 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2059.outbound.protection.outlook.com [104.47.9.59]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a2decac9e58c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 11 Jul 2019 13:45:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=81YSlIP7WzxWfcvsYCXNf5fJdAJCW4/vyLUUTwB30t0=; b=cr27CcJh2jikgkUx1jdVSRi2us6eTTioFXxhBmjYkvEq0C/nf/kXQ36mYYyy+BuiRLZkD0biL8mBve9xfWxpKwZs7pOmtjDw86rFLe6JLEHiVlhtYlD6oGsB6tpZMuGSpDpGfmZXuKlxuAG6I8SXIC+dJm6yJN1WqagmilXFijQ= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.227.22) by DB6PR0802MB2232.eurprd08.prod.outlook.com (10.172.226.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2052.19; Thu, 11 Jul 2019 13:45:18 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::259b:8edf:fb65:2760]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::259b:8edf:fb65:2760%8]) with mapi id 15.20.2052.020; Thu, 11 Jul 2019 13:45:18 +0000 From: Alan Hayward To: "gdb-patches@sourceware.org" CC: nd , Alan Hayward Subject: [PATCH v2 0/5] Arm: Use feature target descriptions Date: Thu, 11 Jul 2019 13:45:00 -0000 Message-ID: <20190711134436.47896-1-alan.hayward@arm.com> Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; X-Microsoft-Antispam-Untrusted: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:DB6PR0802MB2232; x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(346002)(376002)(396003)(136003)(366004)(39860400002)(199004)(189003)(53936002)(99286004)(66476007)(66556008)(64756008)(2906002)(66946007)(71200400001)(5640700003)(478600001)(2501003)(66446008)(44832011)(186003)(71190400001)(316002)(1076003)(6436002)(6512007)(486006)(6916009)(2351001)(66066001)(6486002)(476003)(102836004)(386003)(52116002)(6506007)(8676002)(68736007)(50226002)(26005)(86362001)(7736002)(81166006)(81156014)(2616005)(14454004)(6116002)(4326008)(305945005)(3846002)(36756003)(5660300002)(256004)(14444005)(54906003)(8936002)(25786009);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2232;H:DB6PR0802MB2133.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: C3m3p3Rh3zlyGnzVvDh7gMLSWRglbQdr+HYI4rs4HtHjtE++jjPFc/ZMODviY9qpUjQXgz4UjXXZazwkLiBi5cNtdtQVteArfH7BGsvE+AXB6QUSeQ/5NiM0OVRp/Xd7GPNEY6SV2oLWxIsG8rUznv3pnipCqolQ2Ylwo4RLPhh917uNCxJkRqpI610a3OCoouvJ5SdoJQyrVNL2B5evEGksN0Ex5N44BNH4ZQoW6GkQc7HyyUmK+ENdclGdVnxfIdxJAgKLckYDnFUVMNhtgELusgFh6O2QzU1k8/XipUcK4GPS0GnEgF6fS7wxXFAbCT05VoRoICzNA+yc/uy4jej1AYKY50JJVpSuHS8SZn7eT43PR6TmOfeWrW1L/j7VRftOzVJ6+bk0j123hwA2p1Alwb6pAY3Tj+T0vVnnsWk= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; Return-Path: Alan.Hayward@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 109291a8-241f-400a-3888-08d7060602bc X-IsSubscribed: yes X-SW-Source: 2019-07/txt/msg00299.txt.bz2 Version 2. First two patches from the original set have been pushed. 1 and 4 are updated as per review comments. Otherwise identical. Will push mid next week if there are no more comments. This set of patches is a result of me trying to figure out exactly what is supported for Arm. It moves Arm over to using feature target description= s, simplifying the confusion of xml files in the features/arm/ directory. In addition it helps to further separate out AArch32. There are zero functional changes made by this series. The intention is that all Arm target descriptions are identical before and after the series. All quirks that might seem odd (for example, the Arm with NEON creates a vfp3 feature and then a blank neon feature) have been preserved. One of the patches adds tests to prove the new target descriptions are identical. The final patch then removes these tests (as they block the removal of the xml files). One of the patches breaks the AArch64 gdbserver build, but it is fixed in the following patch. Preventing this would have meant including additional unused functionality, and then removing again. Code has been tested with AArch32, Armv7, and X86 target-all builds. I don't have every Arm target to test this on, but the xml tests should alleviate a= ny=20 issue. Alan Hayward (5): Arm: Add read_description read funcs and use in GDB Arm: Use feature target descriptions Arm: Add xml unit tests Arm: Use read_description funcs in gdbserver Arm: Remove unused feature files and tests gdb/Makefile.in | 5 ++ gdb/aarch32-tdep.c | 33 +++++++++ gdb/aarch32-tdep.h | 25 +++++++ gdb/aarch64-linux-nat.c | 6 +- gdb/arch/aarch32.c | 43 +++++++++++ gdb/arch/aarch32.h | 27 +++++++ gdb/arch/arm.c | 84 ++++++++++++++++++++++ gdb/arch/arm.h | 27 +++++++ gdb/arm-fbsd-tdep.c | 12 ++-- gdb/arm-linux-nat.c | 11 +-- gdb/arm-linux-tdep.c | 11 +-- gdb/arm-tdep.c | 65 +++++++++++------ gdb/arm-tdep.h | 12 ++-- gdb/configure.tgt | 8 ++- gdb/features/arm/arm-with-iwmmxt.c | 83 --------------------- gdb/features/arm/arm-with-iwmmxt.xml | 13 ---- gdb/features/arm/arm-with-m-fpa-layout.c | 46 ------------ gdb/features/arm/arm-with-m-fpa-layout.xml | 46 ------------ gdb/features/arm/arm-with-m-vfp-d16.c | 56 --------------- gdb/features/arm/arm-with-m-vfp-d16.xml | 14 ---- gdb/features/arm/arm-with-m.c | 37 ---------- gdb/features/arm/arm-with-m.xml | 12 ---- gdb/features/arm/arm-with-neon.c | 74 ------------------- gdb/features/arm/arm-with-neon.xml | 14 ---- gdb/features/arm/arm-with-vfpv2.c | 56 --------------- gdb/features/arm/arm-with-vfpv2.xml | 13 ---- gdb/features/arm/arm-with-vfpv3.c | 72 ------------------- gdb/features/arm/arm-with-vfpv3.xml | 13 ---- gdb/gdbserver/configure.srv | 22 ++---- gdb/gdbserver/linux-aarch32-low.c | 2 - gdb/gdbserver/linux-aarch32-low.h | 2 - gdb/gdbserver/linux-aarch32-tdesc.c | 46 ++++++++++++ gdb/gdbserver/linux-aarch32-tdesc.h | 29 ++++++++ gdb/gdbserver/linux-aarch64-low.c | 3 +- gdb/gdbserver/linux-arm-low.c | 77 ++++++++++---------- gdb/gdbserver/linux-arm-tdesc.c | 62 ++++++++++++++++ gdb/gdbserver/linux-arm-tdesc.h | 29 ++++++++ 37 files changed, 532 insertions(+), 658 deletions(-) create mode 100644 gdb/aarch32-tdep.c create mode 100644 gdb/aarch32-tdep.h create mode 100644 gdb/arch/aarch32.c create mode 100644 gdb/arch/aarch32.h delete mode 100644 gdb/features/arm/arm-with-iwmmxt.c delete mode 100644 gdb/features/arm/arm-with-iwmmxt.xml delete mode 100644 gdb/features/arm/arm-with-m-fpa-layout.c delete mode 100644 gdb/features/arm/arm-with-m-fpa-layout.xml delete mode 100644 gdb/features/arm/arm-with-m-vfp-d16.c delete mode 100644 gdb/features/arm/arm-with-m-vfp-d16.xml delete mode 100644 gdb/features/arm/arm-with-m.c delete mode 100644 gdb/features/arm/arm-with-m.xml delete mode 100644 gdb/features/arm/arm-with-neon.c delete mode 100644 gdb/features/arm/arm-with-neon.xml delete mode 100644 gdb/features/arm/arm-with-vfpv2.c delete mode 100644 gdb/features/arm/arm-with-vfpv2.xml delete mode 100644 gdb/features/arm/arm-with-vfpv3.c delete mode 100644 gdb/features/arm/arm-with-vfpv3.xml create mode 100644 gdb/gdbserver/linux-aarch32-tdesc.c create mode 100644 gdb/gdbserver/linux-aarch32-tdesc.h create mode 100644 gdb/gdbserver/linux-arm-tdesc.c create mode 100644 gdb/gdbserver/linux-arm-tdesc.h --=20 2.20.1 (Apple Git-117)