Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Alan Hayward <Alan.Hayward@arm.com>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: nd <nd@arm.com>
Subject: Re: [PATCH v2 1/5] Arm: Add read_description read funcs and use in GDB
Date: Thu, 11 Jul 2019 13:58:00 -0000	[thread overview]
Message-ID: <ff77e4b7-1aae-2648-aa6c-f1e9c096b069@simark.ca> (raw)
In-Reply-To: <20190711134436.47896-2-alan.hayward@arm.com>

Oh, also please test rebuilding each patch against latest master, you will find the
places that need to be changed from "common" to "gdbsupport", such as here:

> diff --git a/gdb/aarch32-tdep.c b/gdb/aarch32-tdep.c
> new file mode 100644
> index 0000000000..d004e0d7f3
> --- /dev/null
> +++ b/gdb/aarch32-tdep.c
> @@ -0,0 +1,33 @@
> +/* Copyright (C) 2019 Free Software Foundation, Inc.
> +
> +   This file is part of GDB.
> +
> +   This program is free software; you can redistribute it and/or modify
> +   it under the terms of the GNU General Public License as published by
> +   the Free Software Foundation; either version 3 of the License, or
> +   (at your option) any later version.
> +
> +   This program is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +   GNU General Public License for more details.
> +
> +   You should have received a copy of the GNU General Public License
> +   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
> +
> +#include "common/common-defs.h"
> +#include "common/common-regcache.h"
> +#include "arch/aarch32.h"

Simon


  parent reply	other threads:[~2019-07-11 13:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-11 13:45 [PATCH v2 0/5] Arm: Use feature target descriptions Alan Hayward
2019-07-11 13:46 ` [PATCH v2 2/5] " Alan Hayward
2019-07-11 13:46 ` [PATCH v2 1/5] Arm: Add read_description read funcs and use in GDB Alan Hayward
2019-07-11 13:56   ` Simon Marchi
2019-07-11 13:58   ` Simon Marchi [this message]
2019-07-11 18:04     ` Alan Hayward
2019-07-11 14:19   ` Simon Marchi
2019-07-11 13:46 ` [PATCH v2 5/5] Arm: Remove unused feature files and tests Alan Hayward
2019-07-11 13:46 ` [PATCH v2 3/5] Arm: Add xml unit tests Alan Hayward
2019-07-11 13:46 ` [PATCH v2 4/5] Arm: Use read_description funcs in gdbserver Alan Hayward
2019-07-11 14:35   ` Simon Marchi
2019-07-19 15:08 ` [PATCH v2 0/5] Arm: Use feature target descriptions Alan Hayward

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff77e4b7-1aae-2648-aa6c-f1e9c096b069@simark.ca \
    --to=simark@simark.ca \
    --cc=Alan.Hayward@arm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox