From: Simon Marchi <simark@simark.ca>
To: Alan Hayward <Alan.Hayward@arm.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: nd <nd@arm.com>
Subject: Re: [PATCH v2 1/5] Arm: Add read_description read funcs and use in GDB
Date: Thu, 11 Jul 2019 13:56:00 -0000 [thread overview]
Message-ID: <2092e6e1-00a2-5482-0d8d-8e71492d2bc2@simark.ca> (raw)
In-Reply-To: <20190711134436.47896-2-alan.hayward@arm.com>
Hi Alan,
Just this nit:
> diff --git a/gdb/aarch64-linux-nat.c b/gdb/aarch64-linux-nat.c
> index 7b60a9a0c3..4db0288e68 100644
> --- a/gdb/aarch64-linux-nat.c
> +++ b/gdb/aarch64-linux-nat.c
> @@ -27,9 +27,11 @@
> #include "target-descriptions.h"
> #include "auxv.h"
> #include "gdbcmd.h"
> +#include "arch/arm.h"
> #include "aarch64-tdep.h"
> #include "aarch64-linux-tdep.h"
> #include "aarch32-linux-nat.h"
> +#include "aarch32-tdep.h"
> #include "arch/arm.h"
> #include "nat/aarch64-linux.h"
> #include "nat/aarch64-linux-hw-point.h"
The "arch/arm.h" include is duplicated here.
Simon
next prev parent reply other threads:[~2019-07-11 13:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 13:45 [PATCH v2 0/5] Arm: Use feature target descriptions Alan Hayward
2019-07-11 13:46 ` [PATCH v2 5/5] Arm: Remove unused feature files and tests Alan Hayward
2019-07-11 13:46 ` [PATCH v2 3/5] Arm: Add xml unit tests Alan Hayward
2019-07-11 13:46 ` [PATCH v2 4/5] Arm: Use read_description funcs in gdbserver Alan Hayward
2019-07-11 14:35 ` Simon Marchi
2019-07-11 13:46 ` [PATCH v2 1/5] Arm: Add read_description read funcs and use in GDB Alan Hayward
2019-07-11 13:56 ` Simon Marchi [this message]
2019-07-11 13:58 ` Simon Marchi
2019-07-11 18:04 ` Alan Hayward
2019-07-11 14:19 ` Simon Marchi
2019-07-11 13:46 ` [PATCH v2 2/5] Arm: Use feature target descriptions Alan Hayward
2019-07-19 15:08 ` [PATCH v2 0/5] " Alan Hayward
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2092e6e1-00a2-5482-0d8d-8e71492d2bc2@simark.ca \
--to=simark@simark.ca \
--cc=Alan.Hayward@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox