From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-157478-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 75869 invoked by alias); 11 Jul 2019 13:56:00 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 75774 invoked by uid 89); 11 Jul 2019 13:55:59 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-18.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: simark.ca
Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Jul 2019 13:55:58 +0000
Received: from [172.16.0.120] (192-222-181-218.qc.cable.ebox.net [192.222.181.218])	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))	(No client certificate requested)	by simark.ca (Postfix) with ESMTPSA id A1C6C1E05C;	Thu, 11 Jul 2019 09:55:56 -0400 (EDT)
Subject: Re: [PATCH v2 1/5] Arm: Add read_description read funcs and use in GDB
To: Alan Hayward <Alan.Hayward@arm.com>, "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: nd <nd@arm.com>
References: <20190711134436.47896-1-alan.hayward@arm.com> <20190711134436.47896-2-alan.hayward@arm.com>
From: Simon Marchi <simark@simark.ca>
Message-ID: <2092e6e1-00a2-5482-0d8d-8e71492d2bc2@simark.ca>
Date: Thu, 11 Jul 2019 13:56:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <20190711134436.47896-2-alan.hayward@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2019-07/txt/msg00306.txt.bz2

Hi Alan,

Just this nit:

> diff --git a/gdb/aarch64-linux-nat.c b/gdb/aarch64-linux-nat.c
> index 7b60a9a0c3..4db0288e68 100644
> --- a/gdb/aarch64-linux-nat.c
> +++ b/gdb/aarch64-linux-nat.c
> @@ -27,9 +27,11 @@
>  #include "target-descriptions.h"
>  #include "auxv.h"
>  #include "gdbcmd.h"
> +#include "arch/arm.h"
>  #include "aarch64-tdep.h"
>  #include "aarch64-linux-tdep.h"
>  #include "aarch32-linux-nat.h"
> +#include "aarch32-tdep.h"
>  #include "arch/arm.h"
>  #include "nat/aarch64-linux.h"
>  #include "nat/aarch64-linux-hw-point.h"

The "arch/arm.h" include is duplicated here.

Simon