From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74239 invoked by alias); 11 Jul 2019 14:19:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 74231 invoked by uid 89); 11 Jul 2019 14:19:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=Switch X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Jul 2019 14:19:28 +0000 Received: from [172.16.0.120] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 392071E05C; Thu, 11 Jul 2019 10:19:27 -0400 (EDT) Subject: Re: [PATCH v2 1/5] Arm: Add read_description read funcs and use in GDB To: Alan Hayward , "gdb-patches@sourceware.org" Cc: nd References: <20190711134436.47896-1-alan.hayward@arm.com> <20190711134436.47896-2-alan.hayward@arm.com> From: Simon Marchi Message-ID: <9b29cdf4-5815-19ec-bfed-7c623d5f6c55@simark.ca> Date: Thu, 11 Jul 2019 14:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190711134436.47896-2-alan.hayward@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-07/txt/msg00309.txt.bz2 On 2019-07-11 9:46 a.m., Alan Hayward wrote: > Switch the Arm target to get target descriptions via arm_read_description > and aarch32_read_description, in the same style as other feature targets. > Add an enum to specify the different types - this will also be of use to > gdbserver in a later patch. > > Under the hood return the same existing pre-feature target descriptions. > > Note: This commit will break the AArch64 gdbserver build. Sorry for spamming you, one last thing :) I forgot to ask you, what is it in this patch that is breaking the AArch64 gdbserver build in this? And what would it take for you not to break it? We generally try to keep things building at each commit, so I'd just like a bit more justifications about why it's worth breaking it here, rather than doing the necessary work to keep it building. Simon