From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 6/7] [gdb/tui] Handle section holes when forward disassembling
Date: Wed, 7 Oct 2026 11:45:38 +0200 [thread overview]
Message-ID: <91f75886-e7fd-4e38-8af2-c4b676a92089@suse.de> (raw)
In-Reply-To: <87tsnghsp8.fsf@tromey.com>
On 9/23/26 5:51 PM, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>
>>> I'm not sure this is the best test. SEC_ALLOC can be set for data
>>> sections as well; e.g. from 'objdump -h' on gdb:
>>> 13 .rodata 00dc0acc 0000000001064d80 0000000001064d80
>>> 00c64d80 2**7
>>> CONTENTS, ALLOC, LOAD, READONLY, DATA
>>> Probably you want SEC_CODE or maybe SEC_ALLOC|SEC_CODE, though I
>>> don't
>>> know if you can ever have code that isn't also 'alloc' (like, what would
>>> be the point).
>>>
>
> Tom> That was my approach in v1, but it got comments [1], so I'm leaving
> Tom> that for now.
>
> I think there's a difference between having the "disassemble" command
> accept data addresses and show the disassembly, and the idea that paging
> through the code might also show data sections.
>
> In the former case, gdb is doing something the user explicitly asked
> for.
>
> In the latter case, though, gdb is probably just showing garbage.
I've submitted a v4 (
https://sourceware.org/pipermail/gdb-patches/2026-October/230915.html )
that includes an RFC patch that skips over data sections when scrolling.
Thanks,
- Tom
next prev parent reply other threads:[~2026-10-07 9:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 9:48 [PATCH v2 0/7] [gdb/tui] Some section hole handling fixes Tom de Vries
2026-09-09 9:48 ` [PATCH v2 1/7] [gdb/tui] Improve tui_disassemble comment Tom de Vries
2026-09-09 9:48 ` [PATCH v2 2/7] [gdb/tui] Fix underflow in tui_find_backward_disassembly_start_address Tom de Vries
2026-09-11 18:12 ` Tom Tromey
2026-09-11 18:14 ` Tom Tromey
2026-09-09 9:48 ` [PATCH v2 3/7] [gdb/tui] Improve section handling " Tom de Vries
2026-09-11 18:26 ` Tom Tromey
2026-09-14 7:31 ` Tom de Vries
2026-09-19 16:01 ` Tom de Vries
2026-09-09 9:48 ` [PATCH v2 4/7] [gdb] replace bsearch with std::lower_bound in find_pc_section Tom de Vries
2026-09-11 18:19 ` Tom Tromey
2026-09-14 7:34 ` Tom de Vries
2026-09-09 9:48 ` [PATCH v2 5/7] [gdb] Add prev/next params to find_pc_section Tom de Vries
2026-09-11 18:40 ` Tom Tromey
2026-09-09 9:48 ` [PATCH v2 6/7] [gdb/tui] Handle section holes when forward disassembling Tom de Vries
2026-09-11 18:39 ` Tom Tromey
2026-09-21 21:29 ` Tom de Vries
2026-09-23 15:51 ` Tom Tromey
2026-10-07 9:45 ` Tom de Vries [this message]
2026-09-09 9:48 ` [PATCH v2 7/7] [gdb/tui] Handle section holes when backward disassembling Tom de Vries
2026-09-11 18:48 ` Tom Tromey
2026-09-19 21:45 ` Tom de Vries
2026-09-11 18:52 ` [PATCH v2 0/7] [gdb/tui] Some section hole handling fixes Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91f75886-e7fd-4e38-8af2-c4b676a92089@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox