Re: [PATCH v2 6/7] [gdb/tui] Handle section holes when forward disassembling

[Tom Tromey <tom@tromey.com>]

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> +	      struct obj_section *next;
Tom> +	      struct obj_section *section
Tom> +		= find_pc_section (pc, nullptr, &next);
Tom> +	      if (section == nullptr
Tom> +		  && next != nullptr
Tom> +		  && ((bfd_section_flags (next->the_bfd_section) & SEC_ALLOC)

I'm not sure this is the best test.  SEC_ALLOC can be set for data
sections as well; e.g. from 'objdump -h' on gdb:

 13 .rodata       00dc0acc  0000000001064d80  0000000001064d80  00c64d80  2**7
                  CONTENTS, ALLOC, LOAD, READONLY, DATA

Probably you want SEC_CODE or maybe SEC_ALLOC|SEC_CODE, though I don't
know if you can ever have code that isn't also 'alloc' (like, what would
be the point).

Then there's the issue that presumably you want to find the next code
section -- but if code and data are interleaved, find_pc_section won't
necessarily return this.

Tom