From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id aoJ4KfhKpGrECwEAWB0awg (envelope-from ) for ; Fri, 11 Sep 2026 14:39:52 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=eldVilgn; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 988821E033; Fri, 11 Sep 2026 14:39:52 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C3E8B1E033 for ; Fri, 11 Sep 2026 14:39:51 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EBDAA4BB5934 for ; Fri, 11 Sep 2026 18:39:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EBDAA4BB5934 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=eldVilgn Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id 3CB7A4BB5934 for ; Fri, 11 Sep 2026 18:39:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3CB7A4BB5934 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3CB7A4BB5934 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789151965; cv=none; b=ZG3EhkAqAevz/65XfE6eXWV+zYwtLcwFdoBBWLqIekmOrY2B7GdAYUtDKb95xkKJcTbHuoJdoPrUKmGGAcSri/UvrpcCPxRNCQ7tyPxBvScDHR7y6t8pDCKQsSNM27GpAzHWzbuT9fs/Him43iULdMJYYJEOJxmSdEpcmrZ6dQg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789151965; c=relaxed/simple; bh=4rBQ6kDgsHY4/kcOyXarnrSN2aJ5HL5mHtcdZpz7MP4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=kvBvjFUhrLaSKEDYifSbp+UlV6Uy2Ntg0Z24tY8tfIIEy7TguRD7k5DJYYSC/jmeltTdHK3oNh1p+OtaxbYNnAoC+HT7vqhb+MDhco3QLO628KvpO6DxGvyLqfhRHTlgXHfmTWk5v+2s7k58AH86JPGZhgvJEDwP7qP8cvHfs7M= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=eldVilgn reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3CB7A4BB5934 Received: from eig-obgw-5006b.ext.cloudfilter.net ([10.0.29.217]) by cmsmtp with ESMTPS id 4rUixnqX9v0nd569jxLCQM; Fri, 11 Sep 2026 18:39:24 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 569ixudAt5NF3569jxLrhO; Fri, 11 Sep 2026 18:39:23 +0000 X-Authority-Analysis: v=2.4 cv=GaMXnRXL c=1 sm=1 tr=0 ts=6aa44adb a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=VdqzKS8jKosA:10 a=ItBw4LHWJt0A:10 a=Quz1mD6rA0xWX9LikPgA:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=z7RGna+zy0vbUuM7ZXSVcwhb5IODI+3wp3FnW7j+06U=; b=eldVilgnLxppBUSDw7sHCYSJeM 8ZdKSApH6cQEBwM5p0xAtcvKvuambqsp8/Flc+tiNQKF4zEoWBX0ZFTyEUfnZU28eOAwR0ioNUv+l 6jjp51pjztnd5CHsNo/OJmMdA; Received: from 97-122-117-2.hlrn.qwest.net ([97.122.117.2]:34796 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.100) (envelope-from ) id 1x569i-000000021U9-24o7; Fri, 11 Sep 2026 12:39:22 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 6/7] [gdb/tui] Handle section holes when forward disassembling In-Reply-To: <20260909094849.2745086-7-tdevries@suse.de> (Tom de Vries's message of "Wed, 9 Sep 2026 11:48:48 +0200") References: <20260909094849.2745086-1-tdevries@suse.de> <20260909094849.2745086-7-tdevries@suse.de> X-Attribution: Tom Date: Fri, 11 Sep 2026 12:39:21 -0600 Message-ID: <87ld97y6na.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.117.2 X-Source-L: No X-Exim-ID: 1x569i-000000021U9-24o7 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-117-2.hlrn.qwest.net (bapiya) [97.122.117.2]:34796 X-Source-Auth: tom+tromey.com X-Email-Count: 10 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfD0g6p+DdtYeR4Nzju7S+E4y478NgPU54okRLZsiFKlov+0cZB4oALXER+YUxRDCmqEeygBnsT7kgkBAMZW0whv/3wXV1RhGm1eFBdBb17zQhQGNcazH eaOznMlizLRPU+YJsCQQBcS+T1jW64IhJgA6sN9ghZnfNLU49GFElGVFG/bk0cA+P6EFcY4yOZrIo09WAGLbYf1Bcwa91ydpJ4g= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Tom" == Tom de Vries writes: Tom> + struct obj_section *next; Tom> + struct obj_section *section Tom> + = find_pc_section (pc, nullptr, &next); Tom> + if (section == nullptr Tom> + && next != nullptr Tom> + && ((bfd_section_flags (next->the_bfd_section) & SEC_ALLOC) I'm not sure this is the best test. SEC_ALLOC can be set for data sections as well; e.g. from 'objdump -h' on gdb: 13 .rodata 00dc0acc 0000000001064d80 0000000001064d80 00c64d80 2**7 CONTENTS, ALLOC, LOAD, READONLY, DATA Probably you want SEC_CODE or maybe SEC_ALLOC|SEC_CODE, though I don't know if you can ever have code that isn't also 'alloc' (like, what would be the point). Then there's the issue that presumably you want to find the next code section -- but if code and data are interleaved, find_pc_section won't necessarily return this. Tom