Re: [PATCH v2 3/7] [gdb/tui] Improve section handling in tui_find_backward_disassembly_start_address

[Tom de Vries <tdevries@suse.de>]

On 9/11/26 8:26 PM, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
> 
> Tom> -  /* Find the section that ADDR is in, and look for the start of the
> Tom> -     section.  */
> Tom> -  struct obj_section *section = find_pc_section (addr);
> Tom> +  /* Find the first section with start address before ADDR, and use its start
> Tom> +     address.  The found section may be the one containing ADDR, or the one
> Tom> +     before it.  */
> Tom> +  struct obj_section *section;
> Tom> +  for (int offset = 0; offset <= 1; ++offset)
> Tom> +    {
> Tom> +      section = find_pc_section (addr - offset);
> Tom> +      if (offset == 0 && section != nullptr && section->addr () == addr)
> Tom> +	{
> Tom> +	  /* If ADDR is the start of its section, use ADDR - 1.  */
> Tom> +	  continue;
> Tom> +	}
> Tom> +
> Tom> +      break;
> Tom> +    }
> 
> I was puzzling about this.  It seems like it would be ok to always check
> "addr-1" here?  Since if addr is not at the start of the section, it
> will return that same section.  And if addr is at the start of the
> section, then that's the answer you want?
> 

Thanks for that observation, that greatly simplifies things.

Thanks,
- Tom

> Tom