From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id clsXFQOjp2q2VgsAWB0awg (envelope-from ) for ; Mon, 14 Sep 2026 03:32:19 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=WyZ8bNdG; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=9ZKtdwDs; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=VGfVSQIq; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Y/n4WlHK; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 443A31E051; Mon, 14 Sep 2026 03:32:19 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 458F31E01F for ; Mon, 14 Sep 2026 03:32:17 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2E5544BAE7F9 for ; Mon, 14 Sep 2026 07:32:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2E5544BAE7F9 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=WyZ8bNdG; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=9ZKtdwDs; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=VGfVSQIq; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Y/n4WlHK Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 4BE9E4B99F51 for ; Mon, 14 Sep 2026 07:31:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4BE9E4B99F51 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4BE9E4B99F51 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789371111; cv=none; b=Iz/jcTWCfMywlGY6WgjkcAWdM7tomVBaGqX9klTpnuWFSApbZI9gEjuFfuclfClUeHtEIJI2S9O+qNTItgcq4MhmogSEKKBYYQXLvhDg12Vy6+AJS/7v923RVFi7c4NGFtTiOH6pyFzw7b8PIjgce7pLOPIy1dKlU+7U8+hzTNo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789371111; c=relaxed/simple; bh=4MyZurtMSw7sdVC0awzU4IhMn32/wT9uZZeu2bpQ/Ac=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=c7bERqiggnLffixVGsurn1qvAGTRiBd09XsQ2d7XiJieoy+ixyBdmTrs4lQZYdkHAzhF1j7e9BtrIwji55rKPqdODf5kGlY70TkbjlCPnSBuLugYe6CIi/jtlLDBK+xi6P/tJlIvHPduyTymrUDJB/LfHDtdVx5pTOFtZxtKAbc= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=WyZ8bNdG; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=9ZKtdwDs; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=VGfVSQIq; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Y/n4WlHK DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4BE9E4B99F51 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 09EA821D73; Mon, 14 Sep 2026 07:31:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1789371106; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/V8vi8gGgaLJGxX72PlwawcxLp8M6yEpEMRp3HQY6cQ=; b=WyZ8bNdGqDtESFs/5tXuW+DpNpy/jHL/0jdKdMqYidEZ7TJqMvXpHmUpuV6GCXbtG7z12Z m6urC6spVwwFs7Kp/TAkS9FJduo2+zAbbTZvWUChokmaajulwGWwaIVq4U4xnO/7RUyppc BK+x3IfrGsBWkJ07S2rMF07vcSttytQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1789371106; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/V8vi8gGgaLJGxX72PlwawcxLp8M6yEpEMRp3HQY6cQ=; b=9ZKtdwDsaR1r5qJg5ZjHJb5hZcF5N8NsvFXVFy32fOGGiMbIvvW0C+BpayAF/UYNtUNOET gBG2f3pEg1Bn+5CA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=VGfVSQIq; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="Y/n4WlHK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1789371102; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/V8vi8gGgaLJGxX72PlwawcxLp8M6yEpEMRp3HQY6cQ=; b=VGfVSQIqZRrBK5YfwQ4IJ8TjgG1mwejNDMYaEjEK4znIEwp0ucb7TXouKJ2VOt8DcbfpuQ Z6MSfW9+n5IAHplHU1d4wcTscCbZa4KaVnVErA1ltyvxZIPc3cRumP2RfngvD3NpR+YYyu h8zwjYboy6R8Zttcri4h3i2H0D7g1/8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1789371102; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/V8vi8gGgaLJGxX72PlwawcxLp8M6yEpEMRp3HQY6cQ=; b=Y/n4WlHKJ0XH2mfXwyPKi8crGxo5f7KbHAT1YmemOgJYYazEHue3qucRgam1cZVjsRr3OC iBOVbhb6gxHTuzBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C589D13693; Mon, 14 Sep 2026 07:31:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id X8dKH92ip2peTQAAD6G6ig (envelope-from ); Mon, 14 Sep 2026 07:31:41 +0000 Message-ID: Date: Mon, 14 Sep 2026 09:31:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/7] [gdb/tui] Improve section handling in tui_find_backward_disassembly_start_address To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260909094849.2745086-1-tdevries@suse.de> <20260909094849.2745086-4-tdevries@suse.de> <87pkyjy78j.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87pkyjy78j.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 09EA821D73 X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; TO_DN_SOME(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim,suse.de:email,suse.de:mid]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/11/26 8:26 PM, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> - /* Find the section that ADDR is in, and look for the start of the > Tom> - section. */ > Tom> - struct obj_section *section = find_pc_section (addr); > Tom> + /* Find the first section with start address before ADDR, and use its start > Tom> + address. The found section may be the one containing ADDR, or the one > Tom> + before it. */ > Tom> + struct obj_section *section; > Tom> + for (int offset = 0; offset <= 1; ++offset) > Tom> + { > Tom> + section = find_pc_section (addr - offset); > Tom> + if (offset == 0 && section != nullptr && section->addr () == addr) > Tom> + { > Tom> + /* If ADDR is the start of its section, use ADDR - 1. */ > Tom> + continue; > Tom> + } > Tom> + > Tom> + break; > Tom> + } > > I was puzzling about this. It seems like it would be ok to always check > "addr-1" here? Since if addr is not at the start of the section, it > will return that same section. And if addr is at the start of the > section, then that's the answer you want? > Thanks for that observation, that greatly simplifies things. Thanks, - Tom > Tom