Re: [PATCH v2 6/7] [gdb/tui] Handle section holes when forward disassembling

[Tom Tromey <tom@tromey.com>]

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

>> I'm not sure this is the best test.  SEC_ALLOC can be set for data
>> sections as well; e.g. from 'objdump -h' on gdb:
>> 13 .rodata       00dc0acc  0000000001064d80  0000000001064d80
>> 00c64d80  2**7
>> CONTENTS, ALLOC, LOAD, READONLY, DATA
>> Probably you want SEC_CODE or maybe SEC_ALLOC|SEC_CODE, though I
>> don't
>> know if you can ever have code that isn't also 'alloc' (like, what would
>> be the point).
>> 

Tom> That was my approach in v1, but it got comments [1], so I'm leaving
Tom> that for now.

I think there's a difference between having the "disassemble" command
accept data addresses and show the disassembly, and the idea that paging
through the code might also show data sections.

In the former case, gdb is doing something the user explicitly asked
for.

In the latter case, though, gdb is probably just showing garbage.

Tom