Re: [PATCH v2 6/7] [gdb/tui] Handle section holes when forward disassembling

[Tom de Vries <tdevries@suse.de>]

On 9/11/26 8:39 PM, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
> 
> Tom> +	      struct obj_section *next;
> Tom> +	      struct obj_section *section
> Tom> +		= find_pc_section (pc, nullptr, &next);
> Tom> +	      if (section == nullptr
> Tom> +		  && next != nullptr
> Tom> +		  && ((bfd_section_flags (next->the_bfd_section) & SEC_ALLOC)
> 
> I'm not sure this is the best test.  SEC_ALLOC can be set for data
> sections as well; e.g. from 'objdump -h' on gdb:
> 
>   13 .rodata       00dc0acc  0000000001064d80  0000000001064d80  00c64d80  2**7
>                    CONTENTS, ALLOC, LOAD, READONLY, DATA
> 
> Probably you want SEC_CODE or maybe SEC_ALLOC|SEC_CODE, though I don't
> know if you can ever have code that isn't also 'alloc' (like, what would
> be the point).
> 

That was my approach in v1, but it got comments [1], so I'm leaving that 
for now.

> Then there's the issue that presumably you want to find the next code
> section -- but if code and data are interleaved, find_pc_section won't
> necessarily return this.

I've come up with a new approach ( v3: 
https://sourceware.org/pipermail/gdb-patches/2026-September/230515.html 
): build an addrmap mirroring what find_pc_section does.

The v3 introduces a function disassemble_skip_sections.  If we indeed 
decide that we don't want to disassemble data sections, then it should 
be easy to address that in there, having effect for all disassembling 
(CLI forward, TUI forward/backward).

Thanks,
- Tom

[1] https://sourceware.org/pipermail/gdb-patches/2026-September/230069.html