[PATCH] Speed up the 'if/else'

[PATCH] Speed up the 'if/else'

[Jiang Jilin]

2009-08-30  Jiang Jilin <freephp@gmail.com>

	* reverse.c (exec_reverse_once): add 'else' to speed up
---
 gdb/reverse.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/gdb/reverse.c b/gdb/reverse.c
index ee59cf3..f2af6d1 100644
--- a/gdb/reverse.c
+++ b/gdb/reverse.c
@@ -48,9 +48,8 @@ exec_reverse_once (char *cmd, char *args, int from_tty)
   struct cleanup *old_chain;
 
   if (dir == EXEC_ERROR)
-    error (_("Target %s does not support this command."), target_shortname);
-
-  if (dir == EXEC_REVERSE)
+    error (_("Target %s does not support this command."), target_shortname); 
+  else if (dir == EXEC_REVERSE)
     error (_("Already in reverse mode.  Use '%s' or 'set exec-dir forward'."),
 	   cmd);
 
-- 
1.5.4.3

Re: [PATCH] Speed up the 'if/else'

[Paul Pluzhnikov]

On Sat, Aug 29, 2009 at 6:12 PM, Jiang Jilin<freephp@gmail.com> wrote:
> 2009-08-30  Jiang Jilin <freephp@gmail.com>
>
>        * reverse.c (exec_reverse_once): add 'else' to speed up

What exactly are you trying to speed up here?

Your patch looks bogus to me (because 'error (...)' call never returns).

> ---
>  gdb/reverse.c |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/gdb/reverse.c b/gdb/reverse.c
> index ee59cf3..f2af6d1 100644
> --- a/gdb/reverse.c
> +++ b/gdb/reverse.c
> @@ -48,9 +48,8 @@ exec_reverse_once (char *cmd, char *args, int from_tty)
>   struct cleanup *old_chain;
>
>   if (dir == EXEC_ERROR)
> -    error (_("Target %s does not support this command."), target_shortname);
> -
> -  if (dir == EXEC_REVERSE)
> +    error (_("Target %s does not support this command."), target_shortname);
> +  else if (dir == EXEC_REVERSE)
>     error (_("Already in reverse mode.  Use '%s' or 'set exec-dir forward'."),
>           cmd);
>
> --
> 1.5.4.3
>
>



-- 
Paul Pluzhnikov

Re: [PATCH] Speed up the 'if/else'

[Jiang Jilin]

On Sun, Aug 30, 2009 at 1:35 PM, Paul Pluzhnikov<ppluzhnikov@google.com> wrote:
> On Sat, Aug 29, 2009 at 6:12 PM, Jiang Jilin<freephp@gmail.com> wrote:
>> 2009-08-30  Jiang Jilin <freephp@gmail.com>
>>
>>        * reverse.c (exec_reverse_once): add 'else' to speed up
>
> What exactly are you trying to speed up here?
>
> Your patch looks bogus to me (because 'error (...)' call never returns).

Thanks for your explanation ! I remember that 'error()' just jumps to
the location in which setjmp() locates.

the patch should be ignored.

Thanks!

Jiang

Re: [PATCH] Speed up the 'if/else'

[Mark Kettenis]

> From: Jiang Jilin <freephp@gmail.com>
> Date: Sun, 30 Aug 2009 09:12:26 +0800
> 
> 2009-08-30  Jiang Jilin <freephp@gmail.com>
> 
> 	* reverse.c (exec_reverse_once): add 'else' to speed up

Sorry, but this is pointless and only makes the code harder to read.

> diff --git a/gdb/reverse.c b/gdb/reverse.c
> index ee59cf3..f2af6d1 100644
> --- a/gdb/reverse.c
> +++ b/gdb/reverse.c
> @@ -48,9 +48,8 @@ exec_reverse_once (char *cmd, char *args, int from_tty)
>    struct cleanup *old_chain;
>  
>    if (dir == EXEC_ERROR)
> -    error (_("Target %s does not support this command."), target_shortname);
> -
> -  if (dir == EXEC_REVERSE)
> +    error (_("Target %s does not support this command."), target_shortname); 
> +  else if (dir == EXEC_REVERSE)
>      error (_("Already in reverse mode.  Use '%s' or 'set exec-dir forward'."),
>  	   cmd);
>  
> -- 
> 1.5.4.3
> 
>