From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27806 invoked by alias); 30 Aug 2009 07:13:55 -0000 Received: (qmail 27795 invoked by uid 22791); 30 Aug 2009 07:13:52 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-qy0-f195.google.com (HELO mail-qy0-f195.google.com) (209.85.221.195) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 30 Aug 2009 07:13:47 +0000 Received: by qyk33 with SMTP id 33so2207886qyk.24 for ; Sun, 30 Aug 2009 00:13:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.119.69 with SMTP id y5mr1183932qcq.100.1251616425179; Sun, 30 Aug 2009 00:13:45 -0700 (PDT) In-Reply-To: <8ac60eac0908292235i7d72bee2jcda6453077669b8a@mail.gmail.com> References: <1251594746-13512-1-git-send-email-freephp@gmail.com> <8ac60eac0908292235i7d72bee2jcda6453077669b8a@mail.gmail.com> From: Jiang Jilin Date: Sun, 30 Aug 2009 08:41:00 -0000 Message-ID: <7d77a27d0908300013v1053bd78l357287173b6e6b9e@mail.gmail.com> Subject: Re: [PATCH] Speed up the 'if/else' To: Paul Pluzhnikov Cc: msnyder@vmware.com, teawater@gmail.com, gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00558.txt.bz2 On Sun, Aug 30, 2009 at 1:35 PM, Paul Pluzhnikov wr= ote: > On Sat, Aug 29, 2009 at 6:12 PM, Jiang Jilin wrote: >> 2009-08-30 =A0Jiang Jilin >> >> =A0 =A0 =A0 =A0* reverse.c (exec_reverse_once): add 'else' to speed up > > What exactly are you trying to speed up here? > > Your patch looks bogus to me (because 'error (...)' call never returns). Thanks for your explanation ! I remember that 'error()' just jumps to the location in which setjmp() locates. the patch should be ignored. Thanks! Jiang