Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jiang Jilin <freephp@gmail.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: msnyder@vmware.com, teawater@gmail.com, gdb-patches@sourceware.org
Subject: Re: [PATCH] Speed up the 'if/else'
Date: Sun, 30 Aug 2009 08:41:00 -0000	[thread overview]
Message-ID: <7d77a27d0908300013v1053bd78l357287173b6e6b9e@mail.gmail.com> (raw)
In-Reply-To: <8ac60eac0908292235i7d72bee2jcda6453077669b8a@mail.gmail.com>

On Sun, Aug 30, 2009 at 1:35 PM, Paul Pluzhnikov<ppluzhnikov@google.com> wrote:
> On Sat, Aug 29, 2009 at 6:12 PM, Jiang Jilin<freephp@gmail.com> wrote:
>> 2009-08-30  Jiang Jilin <freephp@gmail.com>
>>
>>        * reverse.c (exec_reverse_once): add 'else' to speed up
>
> What exactly are you trying to speed up here?
>
> Your patch looks bogus to me (because 'error (...)' call never returns).

Thanks for your explanation ! I remember that 'error()' just jumps to
the location in which setjmp() locates.

the patch should be ignored.

Thanks!

Jiang


  reply	other threads:[~2009-08-30  7:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-30  2:56 Jiang Jilin
2009-08-30  7:13 ` Paul Pluzhnikov
2009-08-30  8:41   ` Jiang Jilin [this message]
2009-08-30 13:15 ` Mark Kettenis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7d77a27d0908300013v1053bd78l357287173b6e6b9e@mail.gmail.com \
    --to=freephp@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@vmware.com \
    --cc=ppluzhnikov@google.com \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox