From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7509 invoked by alias); 30 Aug 2009 08:41:29 -0000 Received: (qmail 7500 invoked by uid 22791); 30 Aug 2009 08:41:28 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 30 Aug 2009 08:41:22 +0000 Received: from brahms.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by brahms.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id n7U8fGH8006900; Sun, 30 Aug 2009 10:41:16 +0200 (CEST) Received: (from kettenis@localhost) by brahms.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id n7U8fFLr030015; Sun, 30 Aug 2009 10:41:15 +0200 (CEST) Date: Sun, 30 Aug 2009 13:15:00 -0000 Message-Id: <200908300841.n7U8fFLr030015@brahms.sibelius.xs4all.nl> From: Mark Kettenis To: freephp@gmail.com CC: msnyder@vmware.com, teawater@gmail.com, gdb-patches@sourceware.org, freephp@gmail.com In-reply-to: <1251594746-13512-1-git-send-email-freephp@gmail.com> (message from Jiang Jilin on Sun, 30 Aug 2009 09:12:26 +0800) Subject: Re: [PATCH] Speed up the 'if/else' References: <> <1251594746-13512-1-git-send-email-freephp@gmail.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00559.txt.bz2 > From: Jiang Jilin > Date: Sun, 30 Aug 2009 09:12:26 +0800 > > 2009-08-30 Jiang Jilin > > * reverse.c (exec_reverse_once): add 'else' to speed up Sorry, but this is pointless and only makes the code harder to read. > diff --git a/gdb/reverse.c b/gdb/reverse.c > index ee59cf3..f2af6d1 100644 > --- a/gdb/reverse.c > +++ b/gdb/reverse.c > @@ -48,9 +48,8 @@ exec_reverse_once (char *cmd, char *args, int from_tty) > struct cleanup *old_chain; > > if (dir == EXEC_ERROR) > - error (_("Target %s does not support this command."), target_shortname); > - > - if (dir == EXEC_REVERSE) > + error (_("Target %s does not support this command."), target_shortname); > + else if (dir == EXEC_REVERSE) > error (_("Already in reverse mode. Use '%s' or 'set exec-dir forward'."), > cmd); > > -- > 1.5.4.3 > >