Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Paul Pluzhnikov <ppluzhnikov@google.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [patch] Eliminate quadratic slow-down on number of solibs (part  	2).
Date: Thu, 21 May 2009 16:17:00 -0000	[thread overview]
Message-ID: <8ac60eac0905210916x30834c0atdb52bcc0c6c5e819@mail.gmail.com> (raw)
In-Reply-To: <20090521151540.GH16152@adacore.com>

On Thu, May 21, 2009 at 8:15 AM, Joel Brobecker <brobecker@adacore.com> wrote:

> I lost track a little. Are there still some patches pending review
> in this series?

Yes, the "hacky patch":
  http://sourceware.org/ml/gdb-patches/2009-05/msg00097.html
saves additional 15% of CPU, because it avoids resetting the breakpoint
on every solib addition, when many solibs are added "at once" (this happens
at program startup/attach on UNIXen, but not on Windows).

Resetting a breakpoint involves non-trivial amount of computation:
bp->addr_string is re-parsed, symbol is looked up, sal's are evaluated, and
finally the breakpoint (on main) is reset to exactly the same location it
were before :-(

I am not happy with the "hackiness" of this patch, but don't see how to
fix this better.

Thanks,
-- 
Paul Pluzhnikov


  parent reply	other threads:[~2009-05-21 16:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-06  0:50 Paul Pluzhnikov
2009-05-12  8:25 ` Joel Brobecker
2009-05-12 20:53   ` Paul Pluzhnikov
2009-05-13  9:27     ` Joel Brobecker
2009-05-13 18:11       ` Paul Pluzhnikov
2009-05-14  8:14         ` Joel Brobecker
2009-05-14 17:45           ` Paul Pluzhnikov
2009-05-14 19:23             ` Joel Brobecker
2009-05-14 23:35               ` Paul Pluzhnikov
     [not found]             ` <20090521151540.GH16152@adacore.com>
2009-05-21 16:17               ` Paul Pluzhnikov [this message]
2009-05-21 16:40                 ` Joel Brobecker
2009-05-30  2:08             ` Tom Tromey
2009-05-30  1:59 ` Tom Tromey
2009-06-03 19:46   ` Paul Pluzhnikov
2009-06-03 21:36     ` Tom Tromey
2009-05-12 19:43 Paul Pluzhnikov
2009-05-13  9:25 ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ac60eac0905210916x30834c0atdb52bcc0c6c5e819@mail.gmail.com \
    --to=ppluzhnikov@google.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox