From: Joel Brobecker <brobecker@adacore.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: gdb-patches@sourceware.org, Tom Tromey <tromey@redhat.com>
Subject: Re: [patch] Eliminate quadratic slow-down on number of solibs (part 2).
Date: Tue, 12 May 2009 08:25:00 -0000 [thread overview]
Message-ID: <20090512082530.GD7584@adacore.com> (raw)
In-Reply-To: <8ac60eac0905051749p3b5d14d9q8903b9de8e18137f@mail.gmail.com>
> Even after the two patches above, there is still some repeated
> and unnecessary setting and resetting of the breakpoints as each
> solib is added :-(
>
> Attached is an alternative patch which subsumes the other two,
> and kills additional 15% of wasted CPU time.
>
> It feels like a hack, but I don't see how to achieve the same
> result in a cleaner way :-(
I haven't had a chance to look at the other patch, but, yeah,
it does feel like a hack! :-/.
But I'm sympathetic to the issue - it's tough to have to wait
an extra 20secs when you know that you don't have any breakpoint
refering to any SO... My thoughts on this: Perhaps a setting
in the "maintenance set/show" that the user could change to deactivate
breakpoint reset. The default is the current behavior, but if the user
knows what he's doing, he can change it. Not sure what the other
maintainers think about that. Horrible, but better than nothing.
That being said, I still think we should try to do as good a job
as we can automatically, so your first suggestion should also be
incorporated.
--
Joel
next prev parent reply other threads:[~2009-05-12 8:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-06 0:50 Paul Pluzhnikov
2009-05-12 8:25 ` Joel Brobecker [this message]
2009-05-12 20:53 ` Paul Pluzhnikov
2009-05-13 9:27 ` Joel Brobecker
2009-05-13 18:11 ` Paul Pluzhnikov
2009-05-14 8:14 ` Joel Brobecker
2009-05-14 17:45 ` Paul Pluzhnikov
2009-05-14 19:23 ` Joel Brobecker
2009-05-14 23:35 ` Paul Pluzhnikov
[not found] ` <20090521151540.GH16152@adacore.com>
2009-05-21 16:17 ` Paul Pluzhnikov
2009-05-21 16:40 ` Joel Brobecker
2009-05-30 2:08 ` Tom Tromey
2009-05-30 1:59 ` Tom Tromey
2009-06-03 19:46 ` Paul Pluzhnikov
2009-06-03 21:36 ` Tom Tromey
2009-05-12 19:43 Paul Pluzhnikov
2009-05-13 9:25 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090512082530.GD7584@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=ppluzhnikov@google.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox