From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20971 invoked by alias); 21 May 2009 16:17:00 -0000 Received: (qmail 20958 invoked by uid 22791); 21 May 2009 16:16:59 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 21 May 2009 16:16:51 +0000 Received: from wpaz1.hot.corp.google.com (wpaz1.hot.corp.google.com [172.24.198.65]) by smtp-out.google.com with ESMTP id n4LGGn0D013749 for ; Thu, 21 May 2009 09:16:49 -0700 Received: from qyk10 (qyk10.prod.google.com [10.241.83.138]) by wpaz1.hot.corp.google.com with ESMTP id n4LGGlPF007974 for ; Thu, 21 May 2009 09:16:48 -0700 Received: by qyk10 with SMTP id 10so842340qyk.26 for ; Thu, 21 May 2009 09:16:47 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.100.9 with SMTP id w9mr1068445qcn.31.1242922607698; Thu, 21 May 2009 09:16:47 -0700 (PDT) In-Reply-To: <20090521151540.GH16152@adacore.com> References: <8ac60eac0905051749p3b5d14d9q8903b9de8e18137f@mail.gmail.com> <20090512082530.GD7584@adacore.com> <8ac60eac0905121353i4aae7110sebb34bec1de0d6d8@mail.gmail.com> <20090513092709.GB7292@adacore.com> <8ac60eac0905131111v7a73a628o5e6dfee5969119d3@mail.gmail.com> <20090514081402.GF7292@adacore.com> <8ac60eac0905141045q93bfc3fo2b22981f3b1d4db1@mail.gmail.com> <20090521151540.GH16152@adacore.com> Date: Thu, 21 May 2009 16:17:00 -0000 Message-ID: <8ac60eac0905210916x30834c0atdb52bcc0c6c5e819@mail.gmail.com> Subject: Re: [patch] Eliminate quadratic slow-down on number of solibs (part 2). From: Paul Pluzhnikov To: Joel Brobecker Cc: gdb-patches Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00461.txt.bz2 On Thu, May 21, 2009 at 8:15 AM, Joel Brobecker wrote: > I lost track a little. Are there still some patches pending review > in this series? Yes, the "hacky patch": http://sourceware.org/ml/gdb-patches/2009-05/msg00097.html saves additional 15% of CPU, because it avoids resetting the breakpoint on every solib addition, when many solibs are added "at once" (this happens at program startup/attach on UNIXen, but not on Windows). Resetting a breakpoint involves non-trivial amount of computation: bp->addr_string is re-parsed, symbol is looked up, sal's are evaluated, and finally the breakpoint (on main) is reset to exactly the same location it were before :-( I am not happy with the "hackiness" of this patch, but don't see how to fix this better. Thanks, -- Paul Pluzhnikov