From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>, "Abid\,
Hafiz" <Hafiz_Abid@mentor.com>,
Joel Brobecker <brobecker@adacore.com>
Subject: Re: [PATCH/python] notify memory changed.
Date: Fri, 22 Jun 2012 14:36:00 -0000 [thread overview]
Message-ID: <87y5nfifdb.fsf@fleche.redhat.com> (raw)
In-Reply-To: <2883062.LPF6KAsNoT@qiyao.dyndns.org> (Yao Qi's message of "Thu, 21 Jun 2012 17:04:19 +0800")
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
>> Do you think it will be useful to have parameters of
>> observer_notify_memory_changed in same order as write_memory. When I looked
>> at this code, I had to look at the function to make sure it was not a typo.
Yao> I am not sure. Both 'write_memory' and 'observer_notify_memory_changed'
Yao> exists here for some years, and I guess people get use to them.
It is fine if you want to change it.
I agree it would be clearer.
Tom
next prev parent reply other threads:[~2012-06-22 14:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 3:16 Yao Qi
2012-06-19 15:14 ` Joel Brobecker
2012-06-20 3:46 ` Yao Qi
2012-06-20 14:52 ` Joel Brobecker
2012-06-21 1:54 ` Yao Qi
2012-06-21 8:52 ` Abid, Hafiz
[not found] ` <2883062.LPF6KAsNoT@qiyao.dyndns.org>
2012-06-22 14:36 ` Tom Tromey [this message]
2012-06-22 14:35 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5nfifdb.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=Hafiz_Abid@mentor.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox