From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4582 invoked by alias); 22 Jun 2012 14:36:11 -0000 Received: (qmail 4368 invoked by uid 22791); 22 Jun 2012 14:36:10 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 22 Jun 2012 14:35:57 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5MEZUta011523 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 22 Jun 2012 10:35:30 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q5MEZSgk015457 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 22 Jun 2012 10:35:29 -0400 From: Tom Tromey To: Yao Qi Cc: , "Abid\, Hafiz" , Joel Brobecker Subject: Re: [PATCH/python] notify memory changed. References: <1340075728-24870-1-git-send-email-yao@codesourcery.com> <1375760.Ghu1pfDITS@qiyao.dyndns.org> <2883062.LPF6KAsNoT@qiyao.dyndns.org> Date: Fri, 22 Jun 2012 14:36:00 -0000 In-Reply-To: <2883062.LPF6KAsNoT@qiyao.dyndns.org> (Yao Qi's message of "Thu, 21 Jun 2012 17:04:19 +0800") Message-ID: <87y5nfifdb.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00698.txt.bz2 >>>>> "Yao" == Yao Qi writes: >> Do you think it will be useful to have parameters of >> observer_notify_memory_changed in same order as write_memory. When I looked >> at this code, I had to look at the function to make sure it was not a typo. Yao> I am not sure. Both 'write_memory' and 'observer_notify_memory_changed' Yao> exists here for some years, and I guess people get use to them. It is fine if you want to change it. I agree it would be clearer. Tom