From: Joel Brobecker <brobecker@adacore.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH/python] notify memory changed.
Date: Tue, 19 Jun 2012 15:14:00 -0000 [thread overview]
Message-ID: <20120619151344.GF19107@adacore.com> (raw)
In-Reply-To: <1340075728-24870-1-git-send-email-yao@codesourcery.com>
> 2012-06-18 Yao Qi <yao@codesourcery.com>
>
> * python/py-inferior.c (infpy_write_memory): Invoke
> observer_notify_memory_changed.
Just wondering if it shouldn't be write_memory itself that should
call observer_notify_memory_changed?
> ---
> gdb/python/py-inferior.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/gdb/python/py-inferior.c b/gdb/python/py-inferior.c
> index efbf14b..bdd39b2 100644
> --- a/gdb/python/py-inferior.c
> +++ b/gdb/python/py-inferior.c
> @@ -494,6 +494,7 @@ infpy_write_memory (PyObject *self, PyObject *args, PyObject *kw)
> break;
> }
> write_memory (addr, buffer, length);
> + observer_notify_memory_changed (addr, length, buffer);
> }
> GDB_PY_HANDLE_EXCEPTION (except);
>
> --
> 1.7.0.4
--
Joel
next prev parent reply other threads:[~2012-06-19 15:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 3:16 Yao Qi
2012-06-19 15:14 ` Joel Brobecker [this message]
2012-06-20 3:46 ` Yao Qi
2012-06-20 14:52 ` Joel Brobecker
2012-06-21 1:54 ` Yao Qi
2012-06-21 8:52 ` Abid, Hafiz
[not found] ` <2883062.LPF6KAsNoT@qiyao.dyndns.org>
2012-06-22 14:36 ` Tom Tromey
2012-06-22 14:35 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120619151344.GF19107@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox