From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6338 invoked by alias); 19 Jun 2012 15:14:13 -0000 Received: (qmail 6325 invoked by uid 22791); 19 Jun 2012 15:14:10 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 19 Jun 2012 15:13:56 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 0FE7C1C71BC; Tue, 19 Jun 2012 11:13:52 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 3AvnxncVLFuE; Tue, 19 Jun 2012 11:13:52 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C41FD1C6F08; Tue, 19 Jun 2012 11:13:51 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 9610B145616; Tue, 19 Jun 2012 08:13:44 -0700 (PDT) Date: Tue, 19 Jun 2012 15:14:00 -0000 From: Joel Brobecker To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH/python] notify memory changed. Message-ID: <20120619151344.GF19107@adacore.com> References: <1340075728-24870-1-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1340075728-24870-1-git-send-email-yao@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00614.txt.bz2 > 2012-06-18 Yao Qi > > * python/py-inferior.c (infpy_write_memory): Invoke > observer_notify_memory_changed. Just wondering if it shouldn't be write_memory itself that should call observer_notify_memory_changed? > --- > gdb/python/py-inferior.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/gdb/python/py-inferior.c b/gdb/python/py-inferior.c > index efbf14b..bdd39b2 100644 > --- a/gdb/python/py-inferior.c > +++ b/gdb/python/py-inferior.c > @@ -494,6 +494,7 @@ infpy_write_memory (PyObject *self, PyObject *args, PyObject *kw) > break; > } > write_memory (addr, buffer, length); > + observer_notify_memory_changed (addr, length, buffer); > } > GDB_PY_HANDLE_EXCEPTION (except); > > -- > 1.7.0.4 -- Joel