Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Cc: Joel Brobecker <brobecker@adacore.com>
Subject: Re: [PATCH/python] notify memory changed.
Date: Wed, 20 Jun 2012 03:46:00 -0000	[thread overview]
Message-ID: <12411572.tk6EVZMAgM@qiyao.dyndns.org> (raw)
In-Reply-To: <20120619151344.GF19107@adacore.com>

On Tuesday 19 June 2012 08:13:44 Joel Brobecker wrote:
> > 2012-06-18  Yao Qi  <yao@codesourcery.com>
> >
> > 
> >
> >       * python/py-inferior.c (infpy_write_memory): Invoke
> >       observer_notify_memory_changed.
> 
> Just wondering if it shouldn't be write_memory itself that should
> call observer_notify_memory_changed?

So far, observer_notify_memory_changed is called in two places, ada-
lang.c:ada_value_assign and valops.c:value_assign.  Looks like they are all 
about memory changes by user-requested operations.  Change in this patch 
belongs to this type (user-requested changes).

The rest of calls to write_memory are about gdb-requested changes to achieve 
some functions, such as inferior call or displaced stepping.  I didn't think 
of carefully the usefulness of notifying observers for operations during inf-
call or displaced stepping.

-- 
Yao (齐尧)


  reply	other threads:[~2012-06-20  3:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-19  3:16 Yao Qi
2012-06-19 15:14 ` Joel Brobecker
2012-06-20  3:46   ` Yao Qi [this message]
2012-06-20 14:52     ` Joel Brobecker
2012-06-21  1:54       ` Yao Qi
2012-06-21  8:52         ` Abid, Hafiz
     [not found]           ` <2883062.LPF6KAsNoT@qiyao.dyndns.org>
2012-06-22 14:36             ` Tom Tromey
2012-06-22 14:35         ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12411572.tk6EVZMAgM@qiyao.dyndns.org \
    --to=yao@codesourcery.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox