From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15299 invoked by alias); 20 Jun 2012 03:46:52 -0000 Received: (qmail 15289 invoked by uid 22791); 20 Jun 2012 03:46:50 -0000 X-SWARE-Spam-Status: No, hits=-4.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 20 Jun 2012 03:46:36 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1ShBsJ-0002N8-On from Yao_Qi@mentor.com ; Tue, 19 Jun 2012 20:46:35 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 19 Jun 2012 20:45:55 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.1.289.1; Tue, 19 Jun 2012 20:46:34 -0700 From: Yao Qi To: CC: Joel Brobecker Subject: Re: [PATCH/python] notify memory changed. Date: Wed, 20 Jun 2012 03:46:00 -0000 Message-ID: <12411572.tk6EVZMAgM@qiyao.dyndns.org> User-Agent: KMail/4.8.3 (Linux/3.3.7-1.fc16.i686; KDE/4.8.3; i686; ; ) In-Reply-To: <20120619151344.GF19107@adacore.com> References: <1340075728-24870-1-git-send-email-yao@codesourcery.com> <20120619151344.GF19107@adacore.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00626.txt.bz2 On Tuesday 19 June 2012 08:13:44 Joel Brobecker wrote: > > 2012-06-18 Yao Qi > > > >=20 > > > > * python/py-inferior.c (infpy_write_memory): Invoke > > observer_notify_memory_changed. >=20 > Just wondering if it shouldn't be write_memory itself that should > call observer_notify_memory_changed? So far, observer_notify_memory_changed is called in two places, ada- lang.c:ada_value_assign and valops.c:value_assign. Looks like they are all= =20 about memory changes by user-requested operations. Change in this patch=20 belongs to this type (user-requested changes). The rest of calls to write_memory are about gdb-requested changes to achiev= e=20 some functions, such as inferior call or displaced stepping. I didn't thin= k=20 of carefully the usefulness of notifying observers for operations during in= f- call or displaced stepping. --=20 Yao (=E9=BD=90=E5=B0=A7)