Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH/python] notify memory changed.
Date: Wed, 20 Jun 2012 14:52:00 -0000	[thread overview]
Message-ID: <20120620145222.GC2799@adacore.com> (raw)
In-Reply-To: <12411572.tk6EVZMAgM@qiyao.dyndns.org>

> The rest of calls to write_memory are about gdb-requested changes to achieve 
> some functions, such as inferior call or displaced stepping.  I didn't think 
> of carefully the usefulness of notifying observers for operations during inf-
> call or displaced stepping.

Hmmm, yes, it is true that we probably don't want to alert the observers
for these (kind of temporary) memory writes. I still worry that we are
going to keep making the same mistake as the one you are fixing here,
but for now I see your point.

Perhaps, for later, we might want to have a look at having two routines,
one "silent", and one that notifies the observers, a little bit like
the routine we have for adding new threads, for instance.

-- 
Joel


  reply	other threads:[~2012-06-20 14:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-19  3:16 Yao Qi
2012-06-19 15:14 ` Joel Brobecker
2012-06-20  3:46   ` Yao Qi
2012-06-20 14:52     ` Joel Brobecker [this message]
2012-06-21  1:54       ` Yao Qi
2012-06-21  8:52         ` Abid, Hafiz
     [not found]           ` <2883062.LPF6KAsNoT@qiyao.dyndns.org>
2012-06-22 14:36             ` Tom Tromey
2012-06-22 14:35         ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120620145222.GC2799@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox