From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9159 invoked by alias); 20 Jun 2012 14:52:41 -0000 Received: (qmail 9148 invoked by uid 22791); 20 Jun 2012 14:52:41 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 20 Jun 2012 14:52:27 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id E13551C7372; Wed, 20 Jun 2012 10:52:26 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ZnHXDUhQHYlm; Wed, 20 Jun 2012 10:52:26 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 9DDE21C736C; Wed, 20 Jun 2012 10:52:25 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 802CD145616; Wed, 20 Jun 2012 07:52:22 -0700 (PDT) Date: Wed, 20 Jun 2012 14:52:00 -0000 From: Joel Brobecker To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH/python] notify memory changed. Message-ID: <20120620145222.GC2799@adacore.com> References: <1340075728-24870-1-git-send-email-yao@codesourcery.com> <20120619151344.GF19107@adacore.com> <12411572.tk6EVZMAgM@qiyao.dyndns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <12411572.tk6EVZMAgM@qiyao.dyndns.org> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00634.txt.bz2 > The rest of calls to write_memory are about gdb-requested changes to achieve > some functions, such as inferior call or displaced stepping. I didn't think > of carefully the usefulness of notifying observers for operations during inf- > call or displaced stepping. Hmmm, yes, it is true that we probably don't want to alert the observers for these (kind of temporary) memory writes. I still worry that we are going to keep making the same mistake as the one you are fixing here, but for now I see your point. Perhaps, for later, we might want to have a look at having two routines, one "silent", and one that notifies the observers, a little bit like the routine we have for adding new threads, for instance. -- Joel