From: Tom Tromey <tom@tromey.com>
To: "Ulrich Weigand" <uweigand@de.ibm.com>
Cc: palves@redhat.com (Pedro Alves), tom@tromey.com (Tom Tromey),
gdb-patches@sourceware.org
Subject: Re: [RFA 2/2] Make some dwarf_expr_context methods pure virtual
Date: Mon, 24 Oct 2016 13:36:00 -0000 [thread overview]
Message-ID: <87y41damyl.fsf@tromey.com> (raw)
In-Reply-To: <20161024122802.AE37B11C284@oc8523832656.ibm.com> (Ulrich Weigand's message of "Mon, 24 Oct 2016 14:28:02 +0200 (CEST)")
>>>>> "Ulrich" == Ulrich Weigand <uweigand@de.ibm.com> writes:
Ulrich> This seems to have broken my SPU daily build (running on RHEL 5 with a
Ulrich> GCC 4.1 system compiler):
Ulrich> gdb/dwarf2expr.h:69: warning: 'struct dwarf_expr_context' has
Ulrich> virtual functions but non-virtual destructor
Ulrich> Is this a C++ version issue?
I don't know. Adding a "virtual" to the destructor is safe though. I
would do it but I'm traveling this week.
Tom
next prev parent reply other threads:[~2016-10-24 13:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 21:51 [RFA 0/2] c++ patch follow-ups Tom Tromey
2016-10-20 21:51 ` [RFA 2/2] Make some dwarf_expr_context methods pure virtual Tom Tromey
2016-10-20 22:21 ` Pedro Alves
2016-10-24 12:28 ` Ulrich Weigand
2016-10-24 13:36 ` Tom Tromey [this message]
2016-10-25 13:22 ` Pedro Alves
2016-10-25 13:29 ` Ulrich Weigand
2016-10-25 13:59 ` [pushed] Make dwarf_expr_context's destructor virtual (Re: [RFA 2/2] Make some dwarf_expr_context methods pure virtual) Pedro Alves
2016-10-25 13:47 ` [RFA 2/2] Make some dwarf_expr_context methods pure virtual Tom Tromey
2016-10-25 14:05 ` Pedro Alves
2016-10-25 16:25 ` Trevor Saunders
2016-10-25 16:57 ` Pedro Alves
2016-10-20 21:51 ` [RFA 1/2] Change minimal_symbol_reader::record_full to take a bool Tom Tromey
2016-10-20 22:14 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y41damyl.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox