From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: palves@redhat.com (Pedro Alves)
Cc: tom@tromey.com (Tom Tromey), gdb-patches@sourceware.org
Subject: Re: [RFA 2/2] Make some dwarf_expr_context methods pure virtual
Date: Mon, 24 Oct 2016 12:28:00 -0000 [thread overview]
Message-ID: <20161024122802.AE37B11C284@oc8523832656.ibm.com> (raw)
In-Reply-To: <b37a65e4-c618-a3a5-d0c1-bd751db261ec@redhat.com> from "Pedro Alves" at Oct 20, 2016 11:21:37 PM
Pedro Alves wrote:
> On 10/20/2016 10:51 PM, Tom Tromey wrote:
> > This patch changes some dwarf_expr_context to be pure virtual, as
> > mentioned during the discussion of an earlier patch in this series.
> >
> > 2016-10-20 Tom Tromey <tom@tromey.com>
> >
> > * dwarf2expr.h (class dwarf_expr_context)
> > <get_frame_base, get_frame_cfa, get_tls_address, dwarf_call,
> > push_dwarf_block_entry_value, get_addr_index, get_object_address>:
> > Now pure virtual.
> > * dwarf2-frame.c (class dwarf_expr_executor)
> > <get_frame_base, get_frame_cfa, get_tls_address, dwarf_call,
> > push_dwarf_block_entry_value, get_addr_index, get_object_address>:
> > New methods.
> > <invalid>: New method.
>
> Nice, thanks. LGTM.
This seems to have broken my SPU daily build (running on RHEL 5 with a
GCC 4.1 system compiler):
gdb/dwarf2expr.h:69: warning: 'struct dwarf_expr_context' has virtual functions but non-virtual destructor
Is this a C++ version issue?
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2016-10-24 12:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 21:51 [RFA 0/2] c++ patch follow-ups Tom Tromey
2016-10-20 21:51 ` [RFA 2/2] Make some dwarf_expr_context methods pure virtual Tom Tromey
2016-10-20 22:21 ` Pedro Alves
2016-10-24 12:28 ` Ulrich Weigand [this message]
2016-10-24 13:36 ` Tom Tromey
2016-10-25 13:22 ` Pedro Alves
2016-10-25 13:29 ` Ulrich Weigand
2016-10-25 13:59 ` [pushed] Make dwarf_expr_context's destructor virtual (Re: [RFA 2/2] Make some dwarf_expr_context methods pure virtual) Pedro Alves
2016-10-25 13:47 ` [RFA 2/2] Make some dwarf_expr_context methods pure virtual Tom Tromey
2016-10-25 14:05 ` Pedro Alves
2016-10-25 16:25 ` Trevor Saunders
2016-10-25 16:57 ` Pedro Alves
2016-10-20 21:51 ` [RFA 1/2] Change minimal_symbol_reader::record_full to take a bool Tom Tromey
2016-10-20 22:14 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161024122802.AE37B11C284@oc8523832656.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox