From: Pedro Alves <palves@redhat.com>
To: Trevor Saunders <tbsaunde@tbsaunde.org>
Cc: Tom Tromey <tom@tromey.com>, Ulrich Weigand <uweigand@de.ibm.com>,
gdb-patches@sourceware.org
Subject: Re: [RFA 2/2] Make some dwarf_expr_context methods pure virtual
Date: Tue, 25 Oct 2016 16:57:00 -0000 [thread overview]
Message-ID: <065e9981-2682-a6b0-945a-c5b829d81e60@redhat.com> (raw)
In-Reply-To: <20161025154131.ilwqo5p5iazfrzqq@ball>
On 10/25/2016 05:33 PM, Trevor Saunders wrote:
> On Tue, Oct 25, 2016 at 03:04:57PM +0100, Pedro Alves wrote:
>> On 10/25/2016 02:47 PM, Tom Tromey wrote:
>>>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>>>
>>> Pedro> Looks like -Wnon-virtual-dtor was removed from (guessing) -Wall
>>> Pedro> at some point.
>>>
>>> Perhaps it's worth adding it explicitly in configure.ac.
>>> (Though I don't know why it was removed from -Wall, so maybe it's not
>>> always appropriate, for reasons I don't know.)
>>
>> Yeah, cross my mind too. I'd like to understand why it was
>> removed first. (I don't know whether it used to be in -Wall, or
>> default, or enabled along some other -Wfoo option.)
>
> with g++ 6 I'm seeing -Wdelete-non-virtual-dtor enabled by -Wall, which
> seems to be warning about the same thing?
>
> oh, accept -wdelete-non-virtual-dtor looks like it wouldn't warn if the
> class is always on the stack like it is here.
Ah, nice. Sounds like we're already covered then.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-10-25 16:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 21:51 [RFA 0/2] c++ patch follow-ups Tom Tromey
2016-10-20 21:51 ` [RFA 2/2] Make some dwarf_expr_context methods pure virtual Tom Tromey
2016-10-20 22:21 ` Pedro Alves
2016-10-24 12:28 ` Ulrich Weigand
2016-10-24 13:36 ` Tom Tromey
2016-10-25 13:22 ` Pedro Alves
2016-10-25 13:29 ` Ulrich Weigand
2016-10-25 13:59 ` [pushed] Make dwarf_expr_context's destructor virtual (Re: [RFA 2/2] Make some dwarf_expr_context methods pure virtual) Pedro Alves
2016-10-25 13:47 ` [RFA 2/2] Make some dwarf_expr_context methods pure virtual Tom Tromey
2016-10-25 14:05 ` Pedro Alves
2016-10-25 16:25 ` Trevor Saunders
2016-10-25 16:57 ` Pedro Alves [this message]
2016-10-20 21:51 ` [RFA 1/2] Change minimal_symbol_reader::record_full to take a bool Tom Tromey
2016-10-20 22:14 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=065e9981-2682-a6b0-945a-c5b829d81e60@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tbsaunde@tbsaunde.org \
--cc=tom@tromey.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox