From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: palves@redhat.com (Pedro Alves)
Cc: tom@tromey.com (Tom Tromey), gdb-patches@sourceware.org
Subject: Re: [RFA 2/2] Make some dwarf_expr_context methods pure virtual
Date: Tue, 25 Oct 2016 13:29:00 -0000 [thread overview]
Message-ID: <20161025132913.E448D11C276@oc8523832656.ibm.com> (raw)
In-Reply-To: <f43759d7-212a-209d-abb6-81340c1ef0ba@redhat.com> from "Pedro Alves" at Oct 25, 2016 02:22:37 PM
Pedro Alves wrote:
> >>>>>> "Ulrich" == Ulrich Weigand <uweigand@de.ibm.com> writes:
> >
> > Ulrich> This seems to have broken my SPU daily build (running on RHEL 5 with a
> > Ulrich> GCC 4.1 system compiler):
>
> Any chance you could install the newer GCC from DTS on that machine?
I don't think there even is a DTS for RHEL 5 on Power, or has that changed?
> Otherwise, if/when we go C++11, that builder will stop working.
Well, once GDB officially no longer supports building with GCC 4.1, I'll
have to come up with another solution; I'll probably just build my own
compiler then. However, as long as GCC 4.1 *is* supported, I think it
is a good to actually still have a system testing that.
(In any case, I'm not sure how long it makes sense to keep the Cell SPU
daily build up and running, given that RHEL 5 is about to go out of
service anyway and more recent distros no longer support Cell ...)
> In file included from .../src/gdb/dwarf2expr.c:28:0:
> .../src/gdb/dwarf2expr.h:68:8: warning: ‘struct dwarf_expr_context’ has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]
> struct dwarf_expr_context
> ^~~~~~~~~~~~~~~~~~
>
> I'll add the "virtual" in a bit.
Thanks!
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2016-10-25 13:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 21:51 [RFA 0/2] c++ patch follow-ups Tom Tromey
2016-10-20 21:51 ` [RFA 1/2] Change minimal_symbol_reader::record_full to take a bool Tom Tromey
2016-10-20 22:14 ` Pedro Alves
2016-10-20 21:51 ` [RFA 2/2] Make some dwarf_expr_context methods pure virtual Tom Tromey
2016-10-20 22:21 ` Pedro Alves
2016-10-24 12:28 ` Ulrich Weigand
2016-10-24 13:36 ` Tom Tromey
2016-10-25 13:22 ` Pedro Alves
2016-10-25 13:29 ` Ulrich Weigand [this message]
2016-10-25 13:59 ` [pushed] Make dwarf_expr_context's destructor virtual (Re: [RFA 2/2] Make some dwarf_expr_context methods pure virtual) Pedro Alves
2016-10-25 13:47 ` [RFA 2/2] Make some dwarf_expr_context methods pure virtual Tom Tromey
2016-10-25 14:05 ` Pedro Alves
2016-10-25 16:25 ` Trevor Saunders
2016-10-25 16:57 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161025132913.E448D11C276@oc8523832656.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox