From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75092 invoked by alias); 25 Oct 2016 16:57:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 73722 invoked by uid 89); 25 Oct 2016 16:57:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Trevor, trevor, saunders, Saunders X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 25 Oct 2016 16:57:21 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A38E27AEA4; Tue, 25 Oct 2016 16:57:20 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9PGvIC7001710; Tue, 25 Oct 2016 12:57:19 -0400 Subject: Re: [RFA 2/2] Make some dwarf_expr_context methods pure virtual To: Trevor Saunders References: <20161024122802.AE37B11C284@oc8523832656.ibm.com> <87y41damyl.fsf@tromey.com> <871sz4a6co.fsf@tromey.com> <09e0354b-b0cf-11e9-de81-05cd77349805@redhat.com> <20161025154131.ilwqo5p5iazfrzqq@ball> Cc: Tom Tromey , Ulrich Weigand , gdb-patches@sourceware.org From: Pedro Alves Message-ID: <065e9981-2682-a6b0-945a-c5b829d81e60@redhat.com> Date: Tue, 25 Oct 2016 16:57:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20161025154131.ilwqo5p5iazfrzqq@ball> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00705.txt.bz2 On 10/25/2016 05:33 PM, Trevor Saunders wrote: > On Tue, Oct 25, 2016 at 03:04:57PM +0100, Pedro Alves wrote: >> On 10/25/2016 02:47 PM, Tom Tromey wrote: >>>>>>>> "Pedro" == Pedro Alves writes: >>> >>> Pedro> Looks like -Wnon-virtual-dtor was removed from (guessing) -Wall >>> Pedro> at some point. >>> >>> Perhaps it's worth adding it explicitly in configure.ac. >>> (Though I don't know why it was removed from -Wall, so maybe it's not >>> always appropriate, for reasons I don't know.) >> >> Yeah, cross my mind too. I'd like to understand why it was >> removed first. (I don't know whether it used to be in -Wall, or >> default, or enabled along some other -Wfoo option.) > > with g++ 6 I'm seeing -Wdelete-non-virtual-dtor enabled by -Wall, which > seems to be warning about the same thing? > > oh, accept -wdelete-non-virtual-dtor looks like it wouldn't warn if the > class is always on the stack like it is here. Ah, nice. Sounds like we're already covered then. Thanks, Pedro Alves