From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76606 invoked by alias); 24 Oct 2016 12:28:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76596 invoked by uid 89); 24 Oct 2016 12:28:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,RCVD_IN_SEMBACKSCATTER,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=4.1, Hx-languages-length:1110, daily X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Oct 2016 12:28:13 +0000 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u9OCOdYj008358 for ; Mon, 24 Oct 2016 08:28:11 -0400 Received: from e06smtp08.uk.ibm.com (e06smtp08.uk.ibm.com [195.75.94.104]) by mx0a-001b2d01.pphosted.com with ESMTP id 269ffv8b9p-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 24 Oct 2016 08:28:10 -0400 Received: from localhost by e06smtp08.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 24 Oct 2016 13:28:08 +0100 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp08.uk.ibm.com (192.168.101.138) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 24 Oct 2016 13:28:05 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id C85B717D8062 for ; Mon, 24 Oct 2016 13:30:18 +0100 (BST) Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u9OCS4Vq27000980 for ; Mon, 24 Oct 2016 12:28:04 GMT Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u9OCS46J004057 for ; Mon, 24 Oct 2016 08:28:04 -0400 Received: from oc8523832656.ibm.com (icon-9-164-155-89.megacenter.de.ibm.com [9.164.155.89]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u9OCS4rr004046; Mon, 24 Oct 2016 08:28:04 -0400 Received: by oc8523832656.ibm.com (Postfix, from userid 500) id AE37B11C284; Mon, 24 Oct 2016 14:28:02 +0200 (CEST) Subject: Re: [RFA 2/2] Make some dwarf_expr_context methods pure virtual To: palves@redhat.com (Pedro Alves) Date: Mon, 24 Oct 2016 12:28:00 -0000 From: "Ulrich Weigand" Cc: tom@tromey.com (Tom Tromey), gdb-patches@sourceware.org In-Reply-To: from "Pedro Alves" at Oct 20, 2016 11:21:37 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16102412-0032-0000-0000-0000022E6887 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16102412-0033-0000-0000-00001D670860 Message-Id: <20161024122802.AE37B11C284@oc8523832656.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-10-24_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1610240222 X-SW-Source: 2016-10/txt/msg00662.txt.bz2 Pedro Alves wrote: > On 10/20/2016 10:51 PM, Tom Tromey wrote: > > This patch changes some dwarf_expr_context to be pure virtual, as > > mentioned during the discussion of an earlier patch in this series. > > > > 2016-10-20 Tom Tromey > > > > * dwarf2expr.h (class dwarf_expr_context) > > > push_dwarf_block_entry_value, get_addr_index, get_object_address>: > > Now pure virtual. > > * dwarf2-frame.c (class dwarf_expr_executor) > > > push_dwarf_block_entry_value, get_addr_index, get_object_address>: > > New methods. > > : New method. > > Nice, thanks. LGTM. This seems to have broken my SPU daily build (running on RHEL 5 with a GCC 4.1 system compiler): gdb/dwarf2expr.h:69: warning: 'struct dwarf_expr_context' has virtual functions but non-virtual destructor Is this a C++ version issue? Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com