From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41213 invoked by alias); 24 Oct 2016 13:36:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41190 invoked by uid 89); 24 Oct 2016 13:36:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.5 required=5.0 tests=BAYES_20,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=4.1, H*RU:10.0.90.82, H*r:CMOut01, H*RU:CMOut01 X-HELO: gproxy5-pub.mail.unifiedlayer.com Received: from gproxy5-pub.mail.unifiedlayer.com (HELO gproxy5-pub.mail.unifiedlayer.com) (67.222.38.55) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Mon, 24 Oct 2016 13:36:14 +0000 Received: (qmail 29734 invoked by uid 0); 24 Oct 2016 13:36:11 -0000 Received: from unknown (HELO CMOut01) (10.0.90.82) by gproxy5.mail.unifiedlayer.com with SMTP; 24 Oct 2016 13:36:11 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id zRc41t00z2f2jeq01Rc7W5; Mon, 24 Oct 2016 07:36:10 -0600 X-Authority-Analysis: v=2.1 cv=beT4Do/B c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=CH0kA5CcgfcA:10 a=VnNF1IyMAAAA:8 a=PQV1NNMsDVFGffpHtg8A:9 a=skCgnbhlp52w9zbo2JeP:22 Received: from atuileries-152-1-26-46.w82-123.abo.wanadoo.fr ([82.123.54.46]:51308 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1byfQ5-0007hs-O2; Mon, 24 Oct 2016 07:36:06 -0600 From: Tom Tromey To: "Ulrich Weigand" Cc: palves@redhat.com (Pedro Alves), tom@tromey.com (Tom Tromey), gdb-patches@sourceware.org Subject: Re: [RFA 2/2] Make some dwarf_expr_context methods pure virtual References: <20161024122802.AE37B11C284@oc8523832656.ibm.com> Date: Mon, 24 Oct 2016 13:36:00 -0000 In-Reply-To: <20161024122802.AE37B11C284@oc8523832656.ibm.com> (Ulrich Weigand's message of "Mon, 24 Oct 2016 14:28:02 +0200 (CEST)") Message-ID: <87y41damyl.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1byfQ5-0007hs-O2 X-Source-Sender: atuileries-152-1-26-46.w82-123.abo.wanadoo.fr (pokyo) [82.123.54.46]:51308 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-10/txt/msg00665.txt.bz2 >>>>> "Ulrich" == Ulrich Weigand writes: Ulrich> This seems to have broken my SPU daily build (running on RHEL 5 with a Ulrich> GCC 4.1 system compiler): Ulrich> gdb/dwarf2expr.h:69: warning: 'struct dwarf_expr_context' has Ulrich> virtual functions but non-virtual destructor Ulrich> Is this a C++ version issue? I don't know. Adding a "virtual" to the destructor is safe though. I would do it but I'm traveling this week. Tom